'Re: Review Request: Important bugfixes to Gpodder Service'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request: Important bugfixes to Gpodder Service
From:       "Lucas Gomes" <x8lucas8x () gmail ! com>
Date:       2011-11-13 2:12:36
Message-ID: 20111113021236.2014.35277 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103122/
-----------------------------------------------------------

(Updated Nov. 13, 2011, 2:12 a.m.)

Review request for Amarok, Stefan Derkits and Bart Cerneels.

Description
-------

This patch must be applied prior to next release.

* Fixed a bug in drag'n drop due to an inappropriate handling of SyncedPodc=
ast.
* Made PodcastModel independent of playlist types.
* Done some changes at SyncedPlaylist and SyncedPodcast.
* Remembered to start subscription synchronisation timer.

Special thanks to HorusHorrendus for informing me about the drag'n drop bug=
 in time ^^.

Diffs
-----

  src/browsers/playlistbrowser/PodcastModel.cpp 1cad82e =

  src/playlistmanager/SyncRelationStorage.cpp 116e23c =

  src/playlistmanager/SyncedPlaylist.h 0e94576 =

  src/playlistmanager/SyncedPlaylist.cpp eaa856f =

  src/playlistmanager/SyncedPodcast.h 85c80fc =

  src/playlistmanager/SyncedPodcast.cpp 92dd6f8 =

  src/services/gpodder/GpodderProvider.cpp 2ba0bf3 =

Diff: http://git.reviewboard.kde.org/r/103122/diff/diff

Testing
-------

Thanks,

Lucas Gomes

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103122/">http://git.reviewboard.kde.org/r/103122/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>

<p style="color: grey;"><i>Updated Nov. 13, 2011, 2:12 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch must be applied prior to next release.

* Fixed a bug in drag&#39;n drop due to an inappropriate handling of SyncedPodcast.
* Made PodcastModel independent of playlist types.
* Done some changes at SyncedPlaylist and SyncedPodcast.
* Remembered to start subscription synchronisation timer.

Special thanks to HorusHorrendus for informing me about the drag&#39;n drop bug in \
time ^^.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: \
grey">(1cad82e)</span></li>

 <li>src/playlistmanager/SyncRelationStorage.cpp <span style="color: \
grey">(116e23c)</span></li>

 <li>src/playlistmanager/SyncedPlaylist.h <span style="color: \
grey">(0e94576)</span></li>

 <li>src/playlistmanager/SyncedPlaylist.cpp <span style="color: \
grey">(eaa856f)</span></li>

 <li>src/playlistmanager/SyncedPodcast.h <span style="color: \
grey">(85c80fc)</span></li>

 <li>src/playlistmanager/SyncedPodcast.cpp <span style="color: \
grey">(92dd6f8)</span></li>

 <li>src/services/gpodder/GpodderProvider.cpp <span style="color: \
grey">(2ba0bf3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103122/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 