'Review Request: [GSoC] Amarok integration with gpodder.net (Playlist'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Review Request: [GSoC] Amarok integration with gpodder.net (Playlist
From:       "Lucas Gomes" <x8lucas8x () gmail ! com>
Date:       2011-10-13 21:25:14
Message-ID: 20111013212514.1501.64090 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102846/
-----------------------------------------------------------

Review request for Amarok, Stefan Derkits and Bart Cerneels.

Description
-------

The attached diff is the work done during this summer to integrate gpodder.=
net web service with Amarok.
Notice that this diff have only playlist synchronisation service related st=
uff.

Diffs
-----

  ChangeLog 14422b1 =

  src/CMakeLists.txt 962070d =

  src/browsers/playlistbrowser/PlaylistBrowserModel.h 76ccb10 =

  src/browsers/playlistbrowser/PlaylistBrowserModel.cpp ff18d83 =

  src/browsers/playlistbrowser/PodcastModel.h ce1a86f =

  src/browsers/playlistbrowser/PodcastModel.cpp 4aad518 =

  src/browsers/playlistbrowser/QtGroupingProxy.cpp e0b4e7a =

  src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 2dcc0cd =

  src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp c64cb97 =

  src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 0a3c99a =

  src/core-impl/podcasts/sql/SqlPodcastMeta.h 0110911 =

  src/core-impl/podcasts/sql/SqlPodcastMeta.cpp e88bc9e =

  src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 83e9b99 =

  src/core/playlists/Playlist.h f88b070 =

  src/core/podcasts/PodcastMeta.h 21364b4 =

  src/core/podcasts/PodcastMeta.cpp fb82fa8 =

  src/main.cpp 7306e84 =

  src/playlistmanager/PlaylistManager.h 54d63b1 =

  src/playlistmanager/PlaylistManager.cpp 333ff17 =

  src/playlistmanager/SyncRelationStorage.h 2a2681d =

  src/playlistmanager/SyncRelationStorage.cpp b151243 =

  src/playlistmanager/SyncedPlaylist.h 54914c7 =

  src/playlistmanager/SyncedPlaylist.cpp c8383b5 =

  src/playlistmanager/SyncedPodcast.h PRE-CREATION =

  src/playlistmanager/SyncedPodcast.cpp PRE-CREATION =

  src/playlistmanager/file/KConfigSyncRelStore.h 4674f66 =

  src/playlistmanager/file/KConfigSyncRelStore.cpp a857593 =

  src/playlistmanager/file/PlaylistFileProvider.cpp 728030d =

  src/playlistmanager/sql/SqlPlaylist.cpp b2a9ca5 =

Diff: http://git.reviewboard.kde.org/r/102846/diff/diff

Testing
-------

This patch is the result of git diff for the range of several commits prior=
 to HEAD, rebased on current master, and should build. Everything is workin=
g as expected and there aren't any known issues.

Thanks,

Lucas Gomes

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102846/">http://git.reviewboard.kde.org/r/102846/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached diff is the work done during this summer to integrate \
gpodder.net web service with Amarok. Notice that this diff have only playlist \
synchronisation service related stuff.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is the result of git diff for the range of several commits \
prior to HEAD, rebased on current master, and should build. Everything is working as \
expected and there aren&#39;t any known issues.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ChangeLog <span style="color: grey">(14422b1)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(962070d)</span></li>

 <li>src/browsers/playlistbrowser/PlaylistBrowserModel.h <span style="color: \
grey">(76ccb10)</span></li>

 <li>src/browsers/playlistbrowser/PlaylistBrowserModel.cpp <span style="color: \
grey">(ff18d83)</span></li>

 <li>src/browsers/playlistbrowser/PodcastModel.h <span style="color: \
grey">(ce1a86f)</span></li>

 <li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: \
grey">(4aad518)</span></li>

 <li>src/browsers/playlistbrowser/QtGroupingProxy.cpp <span style="color: \
grey">(e0b4e7a)</span></li>

 <li>src/core-impl/playlists/types/file/PlaylistFileSupport.cpp <span style="color: \
grey">(2dcc0cd)</span></li>

 <li>src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp <span style="color: \
grey">(c64cb97)</span></li>

 <li>src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp <span style="color: \
grey">(0a3c99a)</span></li>

 <li>src/core-impl/podcasts/sql/SqlPodcastMeta.h <span style="color: \
grey">(0110911)</span></li>

 <li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: \
grey">(e88bc9e)</span></li>

 <li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: \
grey">(83e9b99)</span></li>

 <li>src/core/playlists/Playlist.h <span style="color: grey">(f88b070)</span></li>

 <li>src/core/podcasts/PodcastMeta.h <span style="color: grey">(21364b4)</span></li>

 <li>src/core/podcasts/PodcastMeta.cpp <span style="color: \
grey">(fb82fa8)</span></li>

 <li>src/main.cpp <span style="color: grey">(7306e84)</span></li>

 <li>src/playlistmanager/PlaylistManager.h <span style="color: \
grey">(54d63b1)</span></li>

 <li>src/playlistmanager/PlaylistManager.cpp <span style="color: \
grey">(333ff17)</span></li>

 <li>src/playlistmanager/SyncRelationStorage.h <span style="color: \
grey">(2a2681d)</span></li>

 <li>src/playlistmanager/SyncRelationStorage.cpp <span style="color: \
grey">(b151243)</span></li>

 <li>src/playlistmanager/SyncedPlaylist.h <span style="color: \
grey">(54914c7)</span></li>

 <li>src/playlistmanager/SyncedPlaylist.cpp <span style="color: \
grey">(c8383b5)</span></li>

 <li>src/playlistmanager/SyncedPodcast.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/playlistmanager/SyncedPodcast.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/playlistmanager/file/KConfigSyncRelStore.h <span style="color: \
grey">(4674f66)</span></li>

 <li>src/playlistmanager/file/KConfigSyncRelStore.cpp <span style="color: \
grey">(a857593)</span></li>

 <li>src/playlistmanager/file/PlaylistFileProvider.cpp <span style="color: \
grey">(728030d)</span></li>

 <li>src/playlistmanager/sql/SqlPlaylist.cpp <span style="color: \
grey">(b2a9ca5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102846/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 