[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request: [GSoC] Amarok integration with gpodder.net
From:       "Lucas Gomes" <x8lucas8x () gmail ! com>
Date:       2011-09-26 22:18:48
Message-ID: 20110926221848.7484.67314 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102600/#review6853
-----------------------------------------------------------


To make things easier, everyone can also get this code in my personal clone \
repository.

http://quickgit.kde.org/?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary

- Lucas Gomes


On Sept. 24, 2011, 2:25 p.m., Lucas Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102600/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2011, 2:25 p.m.)
> 
> 
> Review request for Amarok, Stefan Derkits and Bart Cerneels.
> 
> 
> Description
> -------
> 
> The attached diff is the work done during this summer to integrate gpodder.net web \
> service with Amarok. 
> Added features:
> 
> Podcast subscription synchronisation.
> Podcast status synchronisation.
> Browse through podcasts suggested by gpodder.net.
> Browse through gpodder.net top recommended podcasts.
> 
> 
> Diffs
> -----
> 
> src/CMakeLists.txt 962070d 
> src/browsers/playlistbrowser/PlaylistBrowserModel.h 76ccb10 
> src/browsers/playlistbrowser/PlaylistBrowserModel.cpp ff18d83 
> src/browsers/playlistbrowser/PodcastModel.h ce1a86f 
> src/browsers/playlistbrowser/PodcastModel.cpp 4aad518 
> src/browsers/playlistbrowser/QtGroupingProxy.cpp e0b4e7a 
> src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 2dcc0cd 
> src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp c64cb97 
> src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 0a3c99a 
> src/core-impl/podcasts/gpodder/GpodderPodcastMeta.h PRE-CREATION 
> src/core-impl/podcasts/gpodder/GpodderPodcastMeta.cpp PRE-CREATION 
> src/core-impl/podcasts/gpodder/GpodderProvider.h PRE-CREATION 
> src/core-impl/podcasts/gpodder/GpodderProvider.cpp PRE-CREATION 
> src/core-impl/podcasts/sql/SqlPodcastMeta.h 0110911 
> src/core-impl/podcasts/sql/SqlPodcastMeta.cpp e88bc9e 
> src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 83e9b99 
> src/core/playlists/Playlist.h f88b070 
> src/core/podcasts/PodcastMeta.h 21364b4 
> src/core/podcasts/PodcastMeta.cpp fb82fa8 
> src/main.cpp 7306e84 
> src/playlistmanager/PlaylistManager.h 54d63b1 
> src/playlistmanager/PlaylistManager.cpp 333ff17 
> src/playlistmanager/SyncRelationStorage.h 2a2681d 
> src/playlistmanager/SyncRelationStorage.cpp b151243 
> src/playlistmanager/SyncedPlaylist.h 54914c7 
> src/playlistmanager/SyncedPlaylist.cpp c8383b5 
> src/playlistmanager/SyncedPodcast.h PRE-CREATION 
> src/playlistmanager/SyncedPodcast.cpp PRE-CREATION 
> src/playlistmanager/file/KConfigSyncRelStore.h 4674f66 
> src/playlistmanager/file/KConfigSyncRelStore.cpp a857593 
> src/playlistmanager/file/PlaylistFileProvider.cpp 728030d 
> src/playlistmanager/sql/SqlPlaylist.cpp b2a9ca5 
> src/services/gpodder/CMakeLists.txt 97f14b3 
> src/services/gpodder/GpodderConfigWidget.ui PRE-CREATION 
> src/services/gpodder/GpodderService.h fac508a 
> src/services/gpodder/GpodderService.cpp e0cb02f 
> src/services/gpodder/GpodderServiceConfig.h PRE-CREATION 
> src/services/gpodder/GpodderServiceConfig.cpp PRE-CREATION 
> src/services/gpodder/GpodderServiceModel.h 1fbc90d 
> src/services/gpodder/GpodderServiceModel.cpp d899456 
> src/services/gpodder/GpodderServiceSettings.h PRE-CREATION 
> src/services/gpodder/GpodderServiceSettings.cpp PRE-CREATION 
> src/services/gpodder/GpodderTreeItem.h 5698d5b 
> src/services/gpodder/GpodderTreeItem.cpp bfa216e 
> src/services/gpodder/amarok_service_gpodder_config.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102600/diff/diff
> 
> 
> Testing
> -------
> 
> This patch is the result of git diff for the range of several commits prior to \
> HEAD, rebased on current master, and should build. Everything is working as \
> expected and there aren't any known issues. 
> 
> Thanks,
> 
> Lucas Gomes
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102600/">http://git.reviewboard.kde.org/r/102600/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To make things easier, \
everyone can also get this code in my personal clone repository.

http://quickgit.kde.org/?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&amp;a=summary</pre>
  <br />







<p>- Lucas</p>


<br />
<p>On September 24th, 2011, 2:25 p.m., Lucas Gomes wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>


<p style="color: grey;"><i>Updated Sept. 24, 2011, 2:25 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached diff is the work done during this summer to integrate \
gpodder.net web service with Amarok.

Added features:

Podcast subscription synchronisation.
Podcast status synchronisation.
Browse through podcasts suggested by gpodder.net.
Browse through gpodder.net top recommended podcasts.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is the result of git diff for the range of several commits \
prior to HEAD, rebased on current master, and should build. Everything is working as \
expected and there aren&#39;t any known issues.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: grey">(962070d)</span></li>

 <li>src/browsers/playlistbrowser/PlaylistBrowserModel.h <span style="color: \
grey">(76ccb10)</span></li>

 <li>src/browsers/playlistbrowser/PlaylistBrowserModel.cpp <span style="color: \
grey">(ff18d83)</span></li>

 <li>src/browsers/playlistbrowser/PodcastModel.h <span style="color: \
grey">(ce1a86f)</span></li>

 <li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: \
grey">(4aad518)</span></li>

 <li>src/browsers/playlistbrowser/QtGroupingProxy.cpp <span style="color: \
grey">(e0b4e7a)</span></li>

 <li>src/core-impl/playlists/types/file/PlaylistFileSupport.cpp <span style="color: \
grey">(2dcc0cd)</span></li>

 <li>src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp <span style="color: \
grey">(c64cb97)</span></li>

 <li>src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp <span style="color: \
grey">(0a3c99a)</span></li>

 <li>src/core-impl/podcasts/gpodder/GpodderPodcastMeta.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/core-impl/podcasts/gpodder/GpodderPodcastMeta.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/core-impl/podcasts/gpodder/GpodderProvider.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/core-impl/podcasts/gpodder/GpodderProvider.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/core-impl/podcasts/sql/SqlPodcastMeta.h <span style="color: \
grey">(0110911)</span></li>

 <li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: \
grey">(e88bc9e)</span></li>

 <li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: \
grey">(83e9b99)</span></li>

 <li>src/core/playlists/Playlist.h <span style="color: grey">(f88b070)</span></li>

 <li>src/core/podcasts/PodcastMeta.h <span style="color: grey">(21364b4)</span></li>

 <li>src/core/podcasts/PodcastMeta.cpp <span style="color: \
grey">(fb82fa8)</span></li>

 <li>src/main.cpp <span style="color: grey">(7306e84)</span></li>

 <li>src/playlistmanager/PlaylistManager.h <span style="color: \
grey">(54d63b1)</span></li>

 <li>src/playlistmanager/PlaylistManager.cpp <span style="color: \
grey">(333ff17)</span></li>

 <li>src/playlistmanager/SyncRelationStorage.h <span style="color: \
grey">(2a2681d)</span></li>

 <li>src/playlistmanager/SyncRelationStorage.cpp <span style="color: \
grey">(b151243)</span></li>

 <li>src/playlistmanager/SyncedPlaylist.h <span style="color: \
grey">(54914c7)</span></li>

 <li>src/playlistmanager/SyncedPlaylist.cpp <span style="color: \
grey">(c8383b5)</span></li>

 <li>src/playlistmanager/SyncedPodcast.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/playlistmanager/SyncedPodcast.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/playlistmanager/file/KConfigSyncRelStore.h <span style="color: \
grey">(4674f66)</span></li>

 <li>src/playlistmanager/file/KConfigSyncRelStore.cpp <span style="color: \
grey">(a857593)</span></li>

 <li>src/playlistmanager/file/PlaylistFileProvider.cpp <span style="color: \
grey">(728030d)</span></li>

 <li>src/playlistmanager/sql/SqlPlaylist.cpp <span style="color: \
grey">(b2a9ca5)</span></li>

 <li>src/services/gpodder/CMakeLists.txt <span style="color: \
grey">(97f14b3)</span></li>

 <li>src/services/gpodder/GpodderConfigWidget.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderService.h <span style="color: \
grey">(fac508a)</span></li>

 <li>src/services/gpodder/GpodderService.cpp <span style="color: \
grey">(e0cb02f)</span></li>

 <li>src/services/gpodder/GpodderServiceConfig.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderServiceConfig.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderServiceModel.h <span style="color: \
grey">(1fbc90d)</span></li>

 <li>src/services/gpodder/GpodderServiceModel.cpp <span style="color: \
grey">(d899456)</span></li>

 <li>src/services/gpodder/GpodderServiceSettings.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderServiceSettings.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderTreeItem.h <span style="color: \
grey">(5698d5b)</span></li>

 <li>src/services/gpodder/GpodderTreeItem.cpp <span style="color: \
grey">(bfa216e)</span></li>

 <li>src/services/gpodder/amarok_service_gpodder_config.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102600/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic