[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Prevent last.fm credential popup on Amarok start
From: "Bart Cerneels" <bart.cerneels () kde ! org>
Date: 2011-07-25 5:12:30
Message-ID: 20110725051230.22497.87605 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102079/#review5075
-----------------------------------------------------------
src/services/lastfm/LastFmService.cpp
<http://git.reviewboard.kde.org/r/102079/#comment4536>
This should never have been here in the first place. If the service is enabled \
but unconfigured at most a inline error message should be shown. Popup dialogs are \
annoying.
- Bart
On July 24, 2011, 9:36 p.m., Sam Lade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102079/
> -----------------------------------------------------------
>
> (Updated July 24, 2011, 9:36 p.m.)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> As of commit 202c49ebf8b5521b0394b4b7c5e816bf4057c8de, if the Last.FM plugin is \
> enabled, but no username and password are set, a request for the username and \
> password is popped up on Amarok start. This is because this commit calls polish() \
> on each service as it is created. If the service hasn't set m_inited = true when \
> this happens (which is the case when no last.fm username and password are set), a \
> dialogue pops up asking for them.
> This simply removes that call. It was never run in older versions of Amarok, since \
> apparently polish() was never called.
> There may be better ways of doing it, but if so I can't work them out. Everything \
> seems to work properly this way.
>
> Diffs
> -----
>
> src/services/lastfm/LastFmService.cpp ce0b6ec09f3403c44cb26eece994637d2db5db15
>
> Diff: http://git.reviewboard.kde.org/r/102079/diff
>
>
> Testing
> -------
>
> Amarok started with and without last.fm credentials set. Everything seems to behave \
> as expected. No badgering popups are shown.
>
> Thanks,
>
> Sam
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102079/">http://git.reviewboard.kde.org/r/102079/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102079/diff/1/?file=29745#file29745line478" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/services/lastfm/LastFmService.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">LastFmService::updateProfileInfo()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">478</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should \
never have been here in the first place. If the service is enabled but unconfigured \
at most a inline error message should be shown. Popup dialogs are annoying.</pre> \
</div> <br />
<p>- Bart</p>
<br />
<p>On July 24th, 2011, 9:36 p.m., Sam Lade wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sam Lade.</div>
<p style="color: grey;"><i>Updated July 24, 2011, 9:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As of commit 202c49ebf8b5521b0394b4b7c5e816bf4057c8de, if the Last.FM \
plugin is enabled, but no username and password are set, a request for the username \
and password is popped up on Amarok start. This is because this commit calls polish() \
on each service as it is created. If the service hasn't set m_inited = true when \
this happens (which is the case when no last.fm username and password are set), a \
dialogue pops up asking for them.
This simply removes that call. It was never run in older versions of Amarok, since \
apparently polish() was never called.
There may be better ways of doing it, but if so I can't work them out. Everything \
seems to work properly this way.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Amarok started with and without last.fm credentials set. Everything \
seems to behave as expected. No badgering popups are shown.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/lastfm/LastFmService.cpp <span style="color: \
grey">(ce0b6ec09f3403c44cb26eece994637d2db5db15)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102079/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic