[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Update playlist selection at an appropriate time
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2011-07-24 15:23:50
Message-ID: 20110724152350.17716.86843 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101974/#review5035
-----------------------------------------------------------
Ship it!
Makes sense to me.
- Mark
On July 17, 2011, 6:06 a.m., Thomas Karpiniec wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101974/
> -----------------------------------------------------------
> =
> (Updated July 17, 2011, 6:06 a.m.)
> =
> =
> Review request for Amarok.
> =
> =
> Summary
> -------
> =
> When "show only matches" is enabled the listview tries to select the trac=
k and emit a signal about whether or not it matched before the proxy timeou=
t has triggered the update. This happens to work anyway when additional key=
strokes are narrowing the results but causes problems when I typo. For exam=
ple, in my play list, "laz" returns 15 results and "lazz" returns 0. If I t=
hen backspace the second "z", it doesn't select the top track and the linee=
dit widget still appears in red.
> =
> This is a fairly direct solution: moving the relevant selection code to t=
he timeout handler with some member vars to store the required arguments. I=
f there's a better way to go about it please let me know and I'll try to br=
ing it up to scratch.
> =
> =
> Diffs
> -----
> =
> src/playlist/view/listview/PrettyListView.h f22a7c8 =
> src/playlist/view/listview/PrettyListView.cpp 9ce6573 =
> =
> Diff: http://git.reviewboard.kde.org/r/101974/diff
> =
> =
> Testing
> -------
> =
> Applied against master. Tried it with a bunch of different patterns and l=
eft it for a while.
> The only issue I've noticed is that if the list is empty and you press ba=
ckspace then enter in quick succession, it will apply the "enter" to the em=
pty list rather than the one that appears after the timeout. It's an existi=
ng problem though. Might look at that separately.
> =
> =
> Thanks,
> =
> Thomas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101974/">http://git.reviewboard.kde.org/r/101974/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes sense to me.</pre> \
<br />
<p>- Mark</p>
<br />
<p>On July 17th, 2011, 6:06 a.m., Thomas Karpiniec wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Thomas Karpiniec.</div>
<p style="color: grey;"><i>Updated July 17, 2011, 6:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When "show only matches" is enabled the listview tries to \
select the track and emit a signal about whether or not it matched before the proxy \
timeout has triggered the update. This happens to work anyway when additional \
keystrokes are narrowing the results but causes problems when I typo. For example, in \
my play list, "laz" returns 15 results and "lazz" returns 0. If I \
then backspace the second "z", it doesn't select the top track and the \
lineedit widget still appears in red.
This is a fairly direct solution: moving the relevant selection code to the timeout \
handler with some member vars to store the required arguments. If there's a \
better way to go about it please let me know and I'll try to bring it up to \
scratch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Applied against master. Tried it with a bunch of different patterns and \
left it for a while. The only issue I've noticed is that if the list is empty and \
you press backspace then enter in quick succession, it will apply the \
"enter" to the empty list rather than the one that appears after the \
timeout. It's an existing problem though. Might look at that separately.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/playlist/view/listview/PrettyListView.h <span style="color: \
grey">(f22a7c8)</span></li>
<li>src/playlist/view/listview/PrettyListView.cpp <span style="color: \
grey">(9ce6573)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101974/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic