'Re: Review Request: Partial Rewrite of ID3v2TagHelper.cpp'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request: Partial Rewrite of ID3v2TagHelper.cpp
From:       "Stefan Derkits" <stefan () derkits ! at>
Date:       2011-07-22 23:33:52
Message-ID: 20110722233352.3587.12078 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102055/
-----------------------------------------------------------

(Updated July 22, 2011, 11:33 p.m.)

Review request for Amarok and Ralf Engels.

Changes
-------

fixed some bugs introduced by this patch

Summary
-------

Rewrite if else else if Constructs to switch statements

Add common Frame Names to m_fieldMap

Diffs (updated)
-----

  shared/tag_helpers/ID3v2TagHelper.cpp 27e0cf0a9f6dc0bfbbd54cab65cb65dd6be=
f8a33 =

Diff: http://git.reviewboard.kde.org/r/102055/diff

Testing (updated)
-------

compared output of collectionscanner before & after patch -> fixed some, bu=
t still some slight problems with TrackNo

Thanks,

Stefan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102055/">http://git.reviewboard.kde.org/r/102055/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok and Ralf Engels.</div>
<div>By Stefan Derkits.</div>

<p style="color: grey;"><i>Updated July 22, 2011, 11:33 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fixed some bugs introduced by this patch</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rewrite if else else if Constructs to switch statements

Add common Frame Names to m_fieldMap</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compared output of collectionscanner before &amp; after patch -&gt; \
fixed some, but still some slight problems with TrackNo</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: \
grey">(27e0cf0a9f6dc0bfbbd54cab65cb65dd6bef8a33)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102055/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 