'Re: Review Request: Only expose one menubar'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request: Only expose one menubar
From:       "Bart Cerneels" <bart.cerneels () kde ! org>
Date:       2011-03-17 19:18:35
Message-ID: 20110317191835.20159.87102 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100882/#review2017
-----------------------------------------------------------

Ship it!

Yup, it works.

Thanks for reminding me of desktop menubar :) I haven't used it since 3.5 t=
imes because it was a missing feature for a while.

- Bart

On March 17, 2011, 5:29 p.m., Aur=C3=A9lien G=C3=A2teau wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100882/
> -----------------------------------------------------------
> =

> (Updated March 17, 2011, 5:29 p.m.)
> =

> =

> Review request for Amarok.
> =

> =

> Summary
> -------
> =

> ServiceBase creates a KMenuBar. This confuses the Kubuntu widget which al=
lows displaying menubars outside applications ( https://launchpad.net/plasm=
a-widget-menubar ). This simple patch ensures ServiceBase menubar does not =
try to advertise itself as the native menubar of the application.
> =

> =

> Diffs
> -----
> =

>   src/services/ServiceBase.cpp fb7a864 =

> =

> Diff: http://git.reviewboard.kde.org/r/100882/diff
> =

> =

> Testing
> -------
> =

> Started Amarok with and without the Plasma menubar widget, did not notice=
 any unexpected behavior.
> =

> =

> Thanks,
> =

> Aur=C3=A9lien
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100882/">http://git.reviewboard.kde.org/r/100882/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup, it works.

Thanks for reminding me of desktop menubar :) I haven&#39;t used it since 3.5 times \
because it was a missing feature for a while.</pre>  <br />

<p>- Bart</p>

<br />
<p>On March 17th, 2011, 5:29 p.m., Aurélien Gâteau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated March 17, 2011, 5:29 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ServiceBase creates a KMenuBar. This confuses the Kubuntu widget which \
allows displaying menubars outside applications ( \
https://launchpad.net/plasma-widget-menubar ). This simple patch ensures ServiceBase \
menubar does not try to advertise itself as the native menubar of the \
application.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Started Amarok with and without the Plasma menubar widget, did not \
notice any unexpected behavior.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/services/ServiceBase.cpp <span style="color: grey">(fb7a864)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100882/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 