'Re: Review Request: Trivial cosmetic fix to context view 'albums''

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request: Trivial cosmetic fix to context view 'albums'
From:       "Mark Kretschmann" <kretschmann () kde ! org>
Date:       2011-03-06 8:27:35
Message-ID: 20110306082735.21955.81796 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100805/#review1800
-----------------------------------------------------------

Ship it!

Makes sense to me. I think it could go in.

Do you already have commit access to KDE's Git, or should we push the commit for you?

- Mark

On March 5, 2011, 11:36 p.m., Nicholas Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100805/
> -----------------------------------------------------------
> 
> (Updated March 5, 2011, 11:36 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> A suggested fix for bug 263531. Trivial; changes layout in context view 'albums' \
> applet to prevent "0." appearing in front of tracks with no track number set. 
> 
> This addresses bug 263531.
> https://bugs.kde.org/show_bug.cgi?id=263531
> 
> 
> Diffs
> -----
> 
> src/context/applets/albums/AlbumsView.cpp 26c4dca 
> 
> Diff: http://git.reviewboard.kde.org/r/100805/diff
> 
> 
> Testing
> -------
> 
> Works with albums having both tracks with and without track numbers. No number is \
> shown for tracks without a track number and the track title is left aligned in the \
> field (or right in RTL layouts). 
> 
> Thanks,
> 
> Nicholas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100805/">http://git.reviewboard.kde.org/r/100805/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes sense to me. I \
think it could go in.

Do you already have commit access to KDE&#39;s Git, or should we push the commit for \
you?</pre>  <br />

<p>- Mark</p>

<br />
<p>On March 5th, 2011, 11:36 p.m., Nicholas Wilson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Nicholas Wilson.</div>

<p style="color: grey;"><i>Updated March 5, 2011, 11:36 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A suggested fix for bug 263531. Trivial; changes layout in context view \
&#39;albums&#39; applet to prevent &quot;0.&quot; appearing in front of tracks with \
no track number set.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works with albums having both tracks with and without track numbers. No \
number is shown for tracks without a track number and the track title is left aligned \
in the field (or right in RTL layouts).</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=263531">263531</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/context/applets/albums/AlbumsView.cpp <span style="color: \
grey">(26c4dca)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100805/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 