'Re: Review Request: gpodder.net Service (Podcast Directory & Podcast'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request: gpodder.net Service (Podcast Directory & Podcast
From:       "Stefan Derkits" <stefan () derkits ! at>
Date:       2011-03-01 23:50:23
Message-ID: 20110301235023.14855.674 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100582/
-----------------------------------------------------------

(Updated March 1, 2011, 11:50 p.m.)

Review request for Amarok, Leo Franchi and Bart Cerneels.

Changes
-------

This is an updated Review Request that only contains the Service (the Podca=
st Provider will return after 2.4.1 is finished)
The Service should go into 2.4.1 so please test it - you can find the Tarba=
ll of a current Version of libmygpo-qt here: http://stefan.derkits.at/files=
/libmygpo-qt/libmygpo-qt.1.0.0.tar.gz

Still OPML Stuff in this Review Request, please ignore it for the Moment, w=
ill update the Review Request once again when Stecchinos Branch is merged i=
nto Master ;)

Summary
-------

Info about gpodder.net: "gpodder.net is a web service to manage your podcas=
t subscriptions via the web. You can synchronize your devices, view status =
information and discover new interesting podcasts online."

Note: not yet ready for integration, only wanted to already open the Review=
 Request to make our work more public and get Feedback
Additional Note: we've pulled the branch stecchino-IncrementalOpmlDirectory=
 into our Branch ... so the Files related to Opml & the OpmlDirectory are n=
ot "up for Review" here and will be removed from the diff sometime in the F=
uture ;)

Additional Dependency for this Service: libmygpo-qt (http://stefan.derkits.=
at/files/libmygpo-qt/libmygpo-qt.0.10.tar.gz or https://github.com/ase23/li=
bmygpo-qt)

What is added by this Service:
-) a new ServicePlugin with a Config Dialog for gpodder.net Username (synch=
ronise checkbox doesn't do anything at the moment)
-) a gpodder Entry (internet/gpodder) where you can find the TopTags & TopP=
odcasts of these Tags from gpodder.net (not many Tags & Podcast per Tag yet=
, after testing is done we will set it to 50 or 100)
-) a PodcastProvider that should display the Podcasts subscribed to on gpod=
der.net and be able to add a Subscription to gpodder.net (subscribing doesn=
't work yet and displaying has some Bugs)

What Features will come in the Future:
-) display Podcast Data from gpodder.net
-) synchronization of Episode Status (if you listen to an Episode on your p=
hone, it should show up in Amarok as "not new")
-) synchronization of Listening Status (you start to listen to an Episode i=
n Amarok, finish it halfways, click pause/stop and =

Diffs (updated)
-----

  .gitignore b0ad614ce230efbcfcf4f2a84ee7b499caa09116 =

  CMakeLists.txt 11d4c9d5a296560f1c779e1dee4405c9827dac91 =

  README d8c142968c2da3888a703cc2b2e38d854f5c868b =

  cmake/modules/FindLibmygpo-qt.cmake PRE-CREATION =

  src/OpmlOutline.h 8b64dc1c798215e8edbd9081bcd9003a1fe8046e =

  src/OpmlOutline.cpp 5a3d6532b7d06524aeea30705b32fed04426c50e =

  src/OpmlParser.h 28c6c0c1d3ec904f418ef6115bc70258e8badd4a =

  src/OpmlParser.cpp 017c6c28c16079ac62f5a6fc10b225458b26d38e =

  src/OpmlWriter.h c28e76dc73fb575abbc0d8255f0a1d55ca2b5969 =

  src/OpmlWriter.cpp 13a9bf8196ed2a2d0ec48ba552103badca9f5236 =

  src/browsers/playlistbrowser/PodcastModel.cpp c54ba251d3ebcbef83b7f44110b=
ca5e5a846cd98 =

  src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 9784d089292dd8dc3585457=
0db46a801b3daaf16 =

  src/images/CMakeLists.txt 20149eb59120cc5711610908dce8f836d8f0abe3 =

  src/images/emblem-gpodder-scalable.svgz PRE-CREATION =

  src/images/emblem-gpodder.png PRE-CREATION =

  src/images/icons/hi16-action-view-services-gpodder-amarok.png PRE-CREATIO=
N =

  src/images/icons/hi22-action-view-services-gpodder-amarok.png PRE-CREATIO=
N =

  src/images/icons/hi32-action-view-services-gpodder-amarok.png PRE-CREATIO=
N =

  src/images/icons/hi48-action-view-services-gpodder-amarok.png PRE-CREATIO=
N =

  src/images/icons/svg/action-view-services-gpodder-amarok.svgz PRE-CREATIO=
N =

  src/services/CMakeLists.txt 1de81f6fb542d3b9046c408d092c16812724f415 =

  src/services/gpodder/CMakeLists.txt PRE-CREATION =

  src/services/gpodder/GpodderMeta.h PRE-CREATION =

  src/services/gpodder/GpodderMeta.cpp PRE-CREATION =

  src/services/gpodder/GpodderPodcastRequestHandler.h PRE-CREATION =

  src/services/gpodder/GpodderPodcastRequestHandler.cpp PRE-CREATION =

  src/services/gpodder/GpodderPodcastTreeItem.h PRE-CREATION =

  src/services/gpodder/GpodderPodcastTreeItem.cpp PRE-CREATION =

  src/services/gpodder/GpodderService.h PRE-CREATION =

  src/services/gpodder/GpodderService.cpp PRE-CREATION =

  src/services/gpodder/GpodderServiceModel.h PRE-CREATION =

  src/services/gpodder/GpodderServiceModel.cpp PRE-CREATION =

  src/services/gpodder/GpodderServiceView.h PRE-CREATION =

  src/services/gpodder/GpodderServiceView.cpp PRE-CREATION =

  src/services/gpodder/GpodderSortFilterProxyModel.h PRE-CREATION =

  src/services/gpodder/GpodderSortFilterProxyModel.cpp PRE-CREATION =

  src/services/gpodder/GpodderTagTreeItem.h PRE-CREATION =

  src/services/gpodder/GpodderTagTreeItem.cpp PRE-CREATION =

  src/services/gpodder/GpodderTreeItem.h PRE-CREATION =

  src/services/gpodder/GpodderTreeItem.cpp PRE-CREATION =

  src/services/gpodder/amarok_service_gpodder.desktop PRE-CREATION =

  src/services/gpodder/images/CMakeLists.txt PRE-CREATION =

  src/services/gpodder/images/mygpo.png PRE-CREATION =

  src/services/opmldirectory/AddOpmlWidget.ui PRE-CREATION =

  src/services/opmldirectory/CMakeLists.txt 0ad1a93ce03cda502fa56999922e64e=
48da8e757 =

  src/services/opmldirectory/OpmlDirectoryDelegate.h PRE-CREATION =

  src/services/opmldirectory/OpmlDirectoryDelegate.cpp PRE-CREATION =

  src/services/opmldirectory/OpmlDirectoryModel.h PRE-CREATION =

  src/services/opmldirectory/OpmlDirectoryModel.cpp PRE-CREATION =

  src/services/opmldirectory/OpmlDirectoryService.h 978280a36085d8738bb855d=
76d1aa024d3bc0303 =

  src/services/opmldirectory/OpmlDirectoryService.cpp 735b8c0c49abcb0806179=
aef3d95be92358075b2 =

  src/services/opmldirectory/OpmlDirectoryView.h PRE-CREATION =

  src/services/opmldirectory/OpmlDirectoryView.cpp PRE-CREATION =

  src/services/opmldirectory/podcast_directory.opml PRE-CREATION =

  supplementary_scripts/neon/distros/ubuntu/kdesupport-debian/kde-nightly-k=
desupport.install bd570753a0648159935e0c7c12c325f7b5206d9c =

  supplementary_scripts/neon/distros/ubuntu/kdesupport-debian/kde-nightly-k=
desupport.install PRE-CREATION =

Diff: http://git.reviewboard.kde.org/r/100582/diff

Testing
-------

some testing done but still tons of bugs ;)

Thanks,

Stefan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100582/">http://git.reviewboard.kde.org/r/100582/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok, Leo Franchi and Bart Cerneels.</div>
<div>By Stefan Derkits.</div>

<p style="color: grey;"><i>Updated March 1, 2011, 11:50 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is an updated Review Request that only contains the Service (the \
Podcast Provider will return after 2.4.1 is finished) The Service should go into \
2.4.1 so please test it - you can find the Tarball of a current Version of \
libmygpo-qt here: http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.1.0.0.tar.gz

Still OPML Stuff in this Review Request, please ignore it for the Moment, will update \
the Review Request once again when Stecchinos Branch is merged into Master ;)</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Info about gpodder.net: &quot;gpodder.net is a web service to manage \
your podcast subscriptions via the web. You can synchronize your devices, view status \
information and discover new interesting podcasts online.&quot;

Note: not yet ready for integration, only wanted to already open the Review Request \
to make our work more public and get Feedback Additional Note: we&#39;ve pulled the \
branch stecchino-IncrementalOpmlDirectory into our Branch ... so the Files related to \
Opml &amp; the OpmlDirectory are not &quot;up for Review&quot; here and will be \
removed from the diff sometime in the Future ;)

Additional Dependency for this Service: libmygpo-qt \
(http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.0.10.tar.gz or \
https://github.com/ase23/libmygpo-qt)

What is added by this Service:
-) a new ServicePlugin with a Config Dialog for gpodder.net Username (synchronise \
                checkbox doesn&#39;t do anything at the moment)
-) a gpodder Entry (internet/gpodder) where you can find the TopTags &amp; \
TopPodcasts of these Tags from gpodder.net (not many Tags &amp; Podcast per Tag yet, \
                after testing is done we will set it to 50 or 100)
-) a PodcastProvider that should display the Podcasts subscribed to on gpodder.net \
and be able to add a Subscription to gpodder.net (subscribing doesn&#39;t work yet \
and displaying has some Bugs)

What Features will come in the Future:
-) display Podcast Data from gpodder.net
-) synchronization of Episode Status (if you listen to an Episode on your phone, it \
                should show up in Amarok as &quot;not new&quot;)
-) synchronization of Listening Status (you start to listen to an Episode in Amarok, \
finish it halfways, click pause/stop and </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">some testing done but still tons of bugs ;)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>.gitignore <span style="color: \
grey">(b0ad614ce230efbcfcf4f2a84ee7b499caa09116)</span></li>

 <li>CMakeLists.txt <span style="color: \
grey">(11d4c9d5a296560f1c779e1dee4405c9827dac91)</span></li>

 <li>README <span style="color: \
grey">(d8c142968c2da3888a703cc2b2e38d854f5c868b)</span></li>

 <li>cmake/modules/FindLibmygpo-qt.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/OpmlOutline.h <span style="color: \
grey">(8b64dc1c798215e8edbd9081bcd9003a1fe8046e)</span></li>

 <li>src/OpmlOutline.cpp <span style="color: \
grey">(5a3d6532b7d06524aeea30705b32fed04426c50e)</span></li>

 <li>src/OpmlParser.h <span style="color: \
grey">(28c6c0c1d3ec904f418ef6115bc70258e8badd4a)</span></li>

 <li>src/OpmlParser.cpp <span style="color: \
grey">(017c6c28c16079ac62f5a6fc10b225458b26d38e)</span></li>

 <li>src/OpmlWriter.h <span style="color: \
grey">(c28e76dc73fb575abbc0d8255f0a1d55ca2b5969)</span></li>

 <li>src/OpmlWriter.cpp <span style="color: \
grey">(13a9bf8196ed2a2d0ec48ba552103badca9f5236)</span></li>

 <li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: \
grey">(c54ba251d3ebcbef83b7f44110bca5e5a846cd98)</span></li>

 <li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: \
grey">(9784d089292dd8dc35854570db46a801b3daaf16)</span></li>

 <li>src/images/CMakeLists.txt <span style="color: \
grey">(20149eb59120cc5711610908dce8f836d8f0abe3)</span></li>

 <li>src/images/emblem-gpodder-scalable.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/images/emblem-gpodder.png <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/images/icons/hi16-action-view-services-gpodder-amarok.png <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>src/images/icons/hi22-action-view-services-gpodder-amarok.png <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>src/images/icons/hi32-action-view-services-gpodder-amarok.png <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>src/images/icons/hi48-action-view-services-gpodder-amarok.png <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>src/images/icons/svg/action-view-services-gpodder-amarok.svgz <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/CMakeLists.txt <span style="color: \
grey">(1de81f6fb542d3b9046c408d092c16812724f415)</span></li>

 <li>src/services/gpodder/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderMeta.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderMeta.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderPodcastRequestHandler.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderPodcastRequestHandler.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderPodcastTreeItem.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderPodcastTreeItem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderService.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderService.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderServiceModel.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderServiceModel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderServiceView.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderServiceView.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderSortFilterProxyModel.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderSortFilterProxyModel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderTagTreeItem.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderTagTreeItem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderTreeItem.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/GpodderTreeItem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/amarok_service_gpodder.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/images/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/gpodder/images/mygpo.png <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/opmldirectory/AddOpmlWidget.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/opmldirectory/CMakeLists.txt <span style="color: \
grey">(0ad1a93ce03cda502fa56999922e64e48da8e757)</span></li>

 <li>src/services/opmldirectory/OpmlDirectoryDelegate.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/opmldirectory/OpmlDirectoryDelegate.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/opmldirectory/OpmlDirectoryModel.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/opmldirectory/OpmlDirectoryModel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/opmldirectory/OpmlDirectoryService.h <span style="color: \
grey">(978280a36085d8738bb855d76d1aa024d3bc0303)</span></li>

 <li>src/services/opmldirectory/OpmlDirectoryService.cpp <span style="color: \
grey">(735b8c0c49abcb0806179aef3d95be92358075b2)</span></li>

 <li>src/services/opmldirectory/OpmlDirectoryView.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/opmldirectory/OpmlDirectoryView.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/services/opmldirectory/podcast_directory.opml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>supplementary_scripts/neon/distros/ubuntu/kdesupport-debian/kde-nightly-kdesupport.install \
<span style="color: grey">(bd570753a0648159935e0c7c12c325f7b5206d9c)</span></li>

 <li>supplementary_scripts/neon/distros/ubuntu/kdesupport-debian/kde-nightly-kdesupport.install \
<span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100582/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 