[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Refactoring of tag dialog, remove statistics pane
From: "Ralf Engels" <ralf-engels () gmx ! de>
Date: 2011-02-28 19:49:01
Message-ID: 20110228194901.21623.67760 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 28, 2011, 12:08 p.m., Sergey Ivanov wrote:
> > When I try to find tags for several tracks in MusicBrainz DB, TagDialog=
assigns 1 (random) search result to all tracks.
> > And now "Guess Tags From FileName" button always available, doesn't mat=
ter how many tracks are chosen.
Ok. Found it.
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100758/#review1694
-----------------------------------------------------------
On Feb. 27, 2011, 11:27 a.m., Ralf Engels wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100758/
> -----------------------------------------------------------
> =
> (Updated Feb. 27, 2011, 11:27 a.m.)
> =
> =
> Review request for Amarok.
> =
> =
> Summary
> -------
> =
> After discussion with Markey
> =
> Statistics pane was remove
> Editing of rating and score was moved to summary page.
> Other meta information (albums from same artist) were removed as this fun=
ctionality is covered by the context applets and does not belong to a tag e=
dit dialog
> =
> New functionality: if editing multiple tracks from same album the album c=
over can still be edited and the summary page shows the total lenght and to=
tal size of all tracks.
> =
> =
> Diffs
> -----
> =
> src/dialogs/LabelListModel.h 45dd577 =
> src/dialogs/LabelListModel.cpp 565da03 =
> src/dialogs/TagDialog.h 887eeaf =
> src/dialogs/TagDialog.cpp 71eba59 =
> src/dialogs/TagDialogBase.ui cdf33dd =
> =
> Diff: http://git.reviewboard.kde.org/r/100758/diff
> =
> =
> Testing
> -------
> =
> Editing with one and multiple tracks.
> Adding, removing labels.
> Switching between "per Track" and multiple tracks mode and editing variou=
s tags.
> =
> =
> Thanks,
> =
> Ralf
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100758/">http://git.reviewboard.kde.org/r/100758/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 28th, 2011, 12:08 p.m., <b>Sergey \
Ivanov</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When I try to find tags for several tracks in MusicBrainz DB, TagDialog \
assigns 1 (random) search result to all tracks. And now "Guess Tags From \
FileName" button always available, doesn't matter how many tracks are \
chosen.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok. Found it. </pre>
<br />
<p>- Ralf</p>
<br />
<p>On February 27th, 2011, 11:27 a.m., Ralf Engels wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2011, 11:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After discussion with Markey
Statistics pane was remove
Editing of rating and score was moved to summary page.
Other meta information (albums from same artist) were removed as this functionality \
is covered by the context applets and does not belong to a tag edit dialog
New functionality: if editing multiple tracks from same album the album cover can \
still be edited and the summary page shows the total lenght and total size of all \
tracks.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Editing with one and multiple tracks. Adding, removing labels.
Switching between "per Track" and multiple tracks mode and editing various \
tags.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dialogs/LabelListModel.h <span style="color: grey">(45dd577)</span></li>
<li>src/dialogs/LabelListModel.cpp <span style="color: grey">(565da03)</span></li>
<li>src/dialogs/TagDialog.h <span style="color: grey">(887eeaf)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(71eba59)</span></li>
<li>src/dialogs/TagDialogBase.ui <span style="color: grey">(cdf33dd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100758/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic