[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Review Request: Fix Applet::showMessage for KDE 4.6 and trunk
From: "Martin Blumenstingl" <darklight.xdarklight () googlemail ! com>
Date: 2011-02-09 20:08:49
Message-ID: 20110209200849.4383.89932 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100617/
-----------------------------------------------------------
Review request for Amarok.
Summary
-------
There were multiple bugs in libplasma which broke the lyrics applet \
(Applet::showMessage() to be correct). See this BR: \
https://bugs.kde.org/show_bug.cgi?id=265738
This broke the following features:
-The "refresh lyrics" button had no function (it showed the message, but it didn't do \
anything)
-The "you may lose unsaved changes" warning had the same issues as the "refetch \
lyrics" functionality
Unfortunately due to the libplasma bugs the two features of the LyricsApplet will not \
work in KDE 4.6. You either need to patch 4.6 with the following two patches - or \
wait until KDE 4.6.1: \
http://commits.kde.org/kdelibs/6a4bf6e507e5a084ab52a5a7ced1a8cbb70187a8 \
http://commits.kde.org/kdelibs/c9256561d74c9e890c061f4c289a4437a125953d
I fixed the following issues:
-added libplasma >=4.6.0 compatibility
-using amarok with libplasma <4.6.0 should still work (but I haven't tested it)
It's not entirely sure that the signature of the Plasma::Applet::messageButtonClicked \
signal will have the Plasma namespace in the future. But I hope it does.
You may want to follow the discussion here: \
http://mail.kde.org/pipermail/plasma-devel/2011-February/014997.html
Diffs
-----
src/context/Applet.h 35ff00d
src/context/Applet.cpp 3226a8c
src/context/applets/lyrics/LyricsApplet.h 81a5cf9
src/context/applets/lyrics/LyricsApplet.cpp ef2eaaa
Diff: http://git.reviewboard.kde.org/r/100617/diff
Testing
-------
-Tried Amarok with KDE 4.6.0 -> the refetch action works again :)
Thanks,
Martin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100617/">http://git.reviewboard.kde.org/r/100617/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Martin Blumenstingl.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There were multiple bugs in libplasma which broke the lyrics applet \
(Applet::showMessage() to be correct). See this BR: \
https://bugs.kde.org/show_bug.cgi?id=265738
This broke the following features:
-The "refresh lyrics" button had no function (it showed the message, but it \
didn't do anything)
-The "you may lose unsaved changes" warning had the same issues as the \
"refetch lyrics" functionality
Unfortunately due to the libplasma bugs the two features of the LyricsApplet will not \
work in KDE 4.6. You either need to patch 4.6 with the following two patches - or \
wait until KDE 4.6.1: \
http://commits.kde.org/kdelibs/6a4bf6e507e5a084ab52a5a7ced1a8cbb70187a8 \
http://commits.kde.org/kdelibs/c9256561d74c9e890c061f4c289a4437a125953d
I fixed the following issues:
-added libplasma >=4.6.0 compatibility
-using amarok with libplasma <4.6.0 should still work (but I haven't tested \
it)
It's not entirely sure that the signature of the \
Plasma::Applet::messageButtonClicked signal will have the Plasma namespace in the \
future. But I hope it does.
You may want to follow the discussion here: \
http://mail.kde.org/pipermail/plasma-devel/2011-February/014997.html</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">-Tried Amarok with KDE 4.6.0 -> the refetch action works again \
:)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/Applet.h <span style="color: grey">(35ff00d)</span></li>
<li>src/context/Applet.cpp <span style="color: grey">(3226a8c)</span></li>
<li>src/context/applets/lyrics/LyricsApplet.h <span style="color: \
grey">(81a5cf9)</span></li>
<li>src/context/applets/lyrics/LyricsApplet.cpp <span style="color: \
grey">(ef2eaaa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100617/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic