This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100194/

On December 27th, 2010, 9:19 a.m., Sergey Ivanov wrote:

src/MediaDeviceCache.cpp (Diff revision 1) 
MediaDeviceCache::~MediaDeviceCache()
87 
        if ( opt && opt->availableContent() & Solid::OpticalDisc::Audio )
 89 
        if ( opt && (opt->availableContent() & Solid::OpticalDisc::Audio) )
 
& has greater priority then &&, parenthesis don't make difference.
Parenthesis make no difference for the compiler (and most probably also no Speed Difference), but in cases where the Operator Precendence is not that well known, they make the code easier to read --> I would leave them

- Stefan


On December 8th, 2010, 9:55 p.m., Lukáš Tinkl wrote:

Review request for Amarok.
By Lukáš Tinkl.

Updated 2010-12-08 21:55:12

Description 

This patch fixes identifying general USB storage mode media players, plus adds some minor fixes and cleanups. The main change is in UmsConnectionAssistant::identify method.

Diffs

  • src/MediaDeviceCache.cpp (babb8ff)
  • src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp (92339ff)
  • src/core-impl/collections/umscollection/support/UmsConnectionAssistant.cpp (5956a2b)

View Diff

Screenshots

Amarok in USB mode