From amarok-devel Mon Dec 27 10:49:33 2010 From: "Stefan Derkits" Date: Mon, 27 Dec 2010 10:49:33 +0000 To: amarok-devel Subject: Re: Review Request: Fix for USB storage mode media players Message-Id: <20101227104933.13510.81054 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=amarok-devel&m=129344701623995 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0884351951==" --===============0884351951== Content-Type: multipart/alternative; boundary="===============1340961413633723279==" --===============1340961413633723279== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-12-27 09:19:36, Sergey Ivanov wrote: > > src/MediaDeviceCache.cpp, line 89 > > > > > > & has greater priority then &&, parenthesis don't make difference. Parenthesis make no difference for the compiler (and most probably also no = Speed Difference), but in cases where the Operator Precendence is not that = well known, they make the code easier to read --> I would leave them - Stefan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100194/#review621 ----------------------------------------------------------- On 2010-12-08 21:55:12, Luk=C3=A1=C5=A1 Tinkl wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100194/ > ----------------------------------------------------------- > = > (Updated 2010-12-08 21:55:12) > = > = > Review request for Amarok. > = > = > Summary > ------- > = > This patch fixes identifying general USB storage mode media players, plus= adds some minor fixes and cleanups. The main change is in UmsConnectionAss= istant::identify method. > = > = > Diffs > ----- > = > src/MediaDeviceCache.cpp babb8ff = > src/core-impl/collections/ipodcollection/support/IpodConnectionAssistan= t.cpp 92339ff = > src/core-impl/collections/umscollection/support/UmsConnectionAssistant.= cpp 5956a2b = > = > Diff: http://git.reviewboard.kde.org/r/100194/diff > = > = > Testing > ------- > = > = > Screenshots > ----------- > = > Amarok in USB mode > http://git.reviewboard.kde.org/r/100194/s/21/ > = > = > Thanks, > = > Luk=C3=A1=C5=A1 > = > --===============1340961413633723279== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100194/

On December 27th, 2010, 9:19 a.m., Sergey I= vanov wrote:

= = =
src/MediaDeviceCache.cpp (Diff revision 1) 
MediaDeviceCache::~MediaDeviceCache()
87 
        if ( opt &&<=
/span> opt->availableContent() & Solid::OpticalDisc::Audio )
 89 
        if ( opt &&<=
/span> (opt->availableConten=
t() & Solid::OpticalD=
isc::Audio) )
 
& has=
 greater priority then &&, parenthesis don't make difference.
 
Parenthesis make no difference for the compiler (and most probably a=
lso no Speed Difference), but in cases where the Operator Precendence is no=
t that well known, they make the code easier to read --> I would leave t=
hem

- Stefan


On December 8th, 2010, 9:55 p.m., Luk=C3=A1=C5=A1 Tinkl wrote:

Review request for Amarok.
By Luk=C3=A1=C5=A1 Tinkl.

Updated 2010-12-08 21:55:12

Descripti= on 

This patch fixes identifying general USB storage mode media =
players, plus adds some minor fixes and cleanups. The main change is in Ums=
ConnectionAssistant::identify method.

Diffs=

  • src/MediaDeviceCache.cpp (babb8ff)<= /li>
  • src/core-impl/collections/ipodcollection/support/IpodConnectionAssista= nt.cpp (92339ff)
  • src/core-impl/collections/umscollection/support/UmsConnectionAssistant= .cpp (5956a2b)

View Diff

Screensho= ts

--===============1340961413633723279==-- --===============0884351951== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============0884351951==--