[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Playlist Queue Editor
From: "Andreas Hartmetz" <ahartmetz () gmail ! com>
Date: 2010-11-29 23:49:48
Message-ID: 20101129234948.16453.15987 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-11-29 22:53:02, Leo Franchi wrote:
> > Looks good to me now! I'd just shrink it a bit more.. the ratio is still fine, \
> > but the dialog is still quite large. There's room for 50+ queued tracks,that \
> > seems like overkill....
Pushed, thanks. (With a slightly smaller dialog)
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100177/#review442
-----------------------------------------------------------
On 2010-11-29 18:11:59, Andreas Hartmetz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100177/
> -----------------------------------------------------------
>
> (Updated 2010-11-29 18:11:59)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> This adds a Queue Editor, with limited features (move up / move down / clear) like \
> in Amarok 1. The KAction for it is not very well placed in the main UI, I hope you \
> guys can help me. A few design changes were necessary, too, as you can see in the \
> patch.
>
> This addresses bug 198180.
> https://bugs.kde.org/show_bug.cgi?id=198180
>
>
> Diffs
> -----
>
> src/CMakeLists.txt c5ee1e3
> src/MainWindow.cpp f755b6f
> src/likeback/LikeBackBar.cpp 6964f88
> src/playlist/PlaylistActions.h a0b2275
> src/playlist/PlaylistActions.cpp d9284e7
> src/playlist/PlaylistController.cpp f05c250
> src/playlist/PlaylistDock.h f7f1231
> src/playlist/PlaylistDock.cpp 6170f78
> src/playlist/PlaylistItem.h 6bfeb68
> src/playlist/PlaylistModel.h 7b7633f
> src/playlist/PlaylistModel.cpp 0162321
> src/playlist/PlaylistQueueEditor.h PRE-CREATION
> src/playlist/PlaylistQueueEditor.cpp PRE-CREATION
> src/playlist/PlaylistQueueEditor.ui PRE-CREATION
> src/playlist/navigators/DynamicTrackNavigator.cpp a1c67e7
> src/playlist/navigators/StandardTrackNavigator.cpp faeb9f7
> src/playlist/navigators/TrackNavigator.h 6154f9a
> src/playlist/navigators/TrackNavigator.cpp 2a70b08
> src/playlist/proxymodels/AbstractModel.h 03ca4d6
> src/playlist/proxymodels/ProxyBase.h 2e6f9e7
> src/playlist/proxymodels/ProxyBase.cpp 37cb8cb
> src/playlist/view/PlaylistViewCommon.cpp 2a5c9f6
> src/playlist/view/listview/PrettyItemDelegate.cpp 5494279
> src/playlist/view/listview/PrettyListView.cpp 0b2e41e
> src/statusbar/StatusBar.cpp 1a67677
>
> Diff: http://git.reviewboard.kde.org/r/100177/diff
>
>
> Testing
> -------
>
> "worksforme"
>
>
> Thanks,
>
> Andreas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100177/">http://git.reviewboard.kde.org/r/100177/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 29th, 2010, 10:53 p.m., <b>Leo \
Franchi</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks good to me now! I'd just shrink it a bit more.. the ratio is \
still fine, but the dialog is still quite large. There's room for 50+ queued \
tracks,that seems like overkill....</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pushed, thanks. (With a \
slightly smaller dialog)</pre> <br />
<p>- Andreas</p>
<br />
<p>On November 29th, 2010, 6:11 p.m., Andreas Hartmetz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Andreas Hartmetz.</div>
<p style="color: grey;"><i>Updated 2010-11-29 18:11:59</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds a Queue Editor, with limited features (move up / move down / \
clear) like in Amarok 1. The KAction for it is not very well placed in the main UI, I \
hope you guys can help me. A few design changes were necessary, too, as you can see \
in the patch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">"worksforme"</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=198180">198180</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(c5ee1e3)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(f755b6f)</span></li>
<li>src/likeback/LikeBackBar.cpp <span style="color: grey">(6964f88)</span></li>
<li>src/playlist/PlaylistActions.h <span style="color: grey">(a0b2275)</span></li>
<li>src/playlist/PlaylistActions.cpp <span style="color: grey">(d9284e7)</span></li>
<li>src/playlist/PlaylistController.cpp <span style="color: \
grey">(f05c250)</span></li>
<li>src/playlist/PlaylistDock.h <span style="color: grey">(f7f1231)</span></li>
<li>src/playlist/PlaylistDock.cpp <span style="color: grey">(6170f78)</span></li>
<li>src/playlist/PlaylistItem.h <span style="color: grey">(6bfeb68)</span></li>
<li>src/playlist/PlaylistModel.h <span style="color: grey">(7b7633f)</span></li>
<li>src/playlist/PlaylistModel.cpp <span style="color: grey">(0162321)</span></li>
<li>src/playlist/PlaylistQueueEditor.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/playlist/PlaylistQueueEditor.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/playlist/PlaylistQueueEditor.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/playlist/navigators/DynamicTrackNavigator.cpp <span style="color: \
grey">(a1c67e7)</span></li>
<li>src/playlist/navigators/StandardTrackNavigator.cpp <span style="color: \
grey">(faeb9f7)</span></li>
<li>src/playlist/navigators/TrackNavigator.h <span style="color: \
grey">(6154f9a)</span></li>
<li>src/playlist/navigators/TrackNavigator.cpp <span style="color: \
grey">(2a70b08)</span></li>
<li>src/playlist/proxymodels/AbstractModel.h <span style="color: \
grey">(03ca4d6)</span></li>
<li>src/playlist/proxymodels/ProxyBase.h <span style="color: \
grey">(2e6f9e7)</span></li>
<li>src/playlist/proxymodels/ProxyBase.cpp <span style="color: \
grey">(37cb8cb)</span></li>
<li>src/playlist/view/PlaylistViewCommon.cpp <span style="color: \
grey">(2a5c9f6)</span></li>
<li>src/playlist/view/listview/PrettyItemDelegate.cpp <span style="color: \
grey">(5494279)</span></li>
<li>src/playlist/view/listview/PrettyListView.cpp <span style="color: \
grey">(0b2e41e)</span></li>
<li>src/statusbar/StatusBar.cpp <span style="color: grey">(1a67677)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100177/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic