[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: GSoC: Transcoding
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2010-11-12 6:45:22
Message-ID: 20101112064522.7701.72400 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100068/#review335
-----------------------------------------------------------
Any progress on this one?
- Mark
On 2010-10-17 20:51:11, Teo Mrnjavac wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100068/
> -----------------------------------------------------------
> =
> (Updated 2010-10-17 20:51:11)
> =
> =
> Review request for Amarok.
> =
> =
> Summary
> -------
> =
> The attached diff is the work done during this summer to implement transc=
oding, it should apply to master as of right now. There are some known issu=
es with how FFmpeg behaves with metadata, and I'm not sure I made all the r=
ight choices with how I modified CollectionLocation-related stuff.
> =
> =
> Diffs
> -----
> =
> src/App.cpp 445fdc3 =
> src/CMakeLists.txt f8559c4 =
> src/browsers/CollectionTreeView.h 63c99b5 =
> src/browsers/CollectionTreeView.cpp ed34beb =
> src/browsers/filebrowser/FileView.h 11547fe =
> src/browsers/filebrowser/FileView.cpp 9cb7c27 =
> src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLo=
cation.h f65cd4c =
> src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLo=
cation.cpp a858d44 =
> src/core-impl/collections/sqlcollection/CMakeLists.txt f530d67 =
> src/core-impl/collections/sqlcollection/SqlCollectionFactory.cpp a1966a=
c =
> src/core-impl/collections/sqlcollection/SqlCollectionLocation.h ec3a6d8 =
> src/core-impl/collections/sqlcollection/SqlCollectionLocation.cpp 4b023=
fc =
> src/core/CMakeLists.txt 5863ca1 =
> src/core/collections/CollectionLocation.h 567f6d3 =
> src/core/collections/CollectionLocation.cpp dbf3b37 =
> src/core/transcoding/TranscodingConfiguration.h PRE-CREATION =
> src/core/transcoding/TranscodingConfiguration.cpp PRE-CREATION =
> src/core/transcoding/TranscodingController.h PRE-CREATION =
> src/core/transcoding/TranscodingController.cpp PRE-CREATION =
> src/core/transcoding/TranscodingDefines.h PRE-CREATION =
> src/core/transcoding/TranscodingFormat.h PRE-CREATION =
> src/core/transcoding/TranscodingProperty.h PRE-CREATION =
> src/core/transcoding/TranscodingProperty.cpp PRE-CREATION =
> src/core/transcoding/formats/TranscodingAacFormat.h PRE-CREATION =
> src/core/transcoding/formats/TranscodingAacFormat.cpp PRE-CREATION =
> src/core/transcoding/formats/TranscodingAlacFormat.h PRE-CREATION =
> src/core/transcoding/formats/TranscodingAlacFormat.cpp PRE-CREATION =
> src/core/transcoding/formats/TranscodingFlacFormat.h PRE-CREATION =
> src/core/transcoding/formats/TranscodingFlacFormat.cpp PRE-CREATION =
> src/core/transcoding/formats/TranscodingMp3Format.h PRE-CREATION =
> src/core/transcoding/formats/TranscodingMp3Format.cpp PRE-CREATION =
> src/core/transcoding/formats/TranscodingNullFormat.h PRE-CREATION =
> src/core/transcoding/formats/TranscodingNullFormat.cpp PRE-CREATION =
> src/core/transcoding/formats/TranscodingVorbisFormat.h PRE-CREATION =
> src/core/transcoding/formats/TranscodingVorbisFormat.cpp PRE-CREATION =
> src/core/transcoding/formats/TranscodingWmaFormat.h PRE-CREATION =
> src/core/transcoding/formats/TranscodingWmaFormat.cpp PRE-CREATION =
> src/dialogs/OrganizeCollectionDialog.h 2c0adf7 =
> src/dialogs/OrganizeCollectionDialog.cpp 2607e99 =
> src/dialogs/TrackOrganizer.h 9d62467 =
> src/dialogs/TrackOrganizer.cpp 135d520 =
> src/transcoding/CMakeLists.txt PRE-CREATION =
> src/transcoding/TranscodingAssistantDialog.h PRE-CREATION =
> src/transcoding/TranscodingAssistantDialog.cpp PRE-CREATION =
> src/transcoding/TranscodingAssistantDialog.ui PRE-CREATION =
> src/transcoding/TranscodingJob.h PRE-CREATION =
> src/transcoding/TranscodingJob.cpp PRE-CREATION =
> src/transcoding/TranscodingOptionsStackedWidget.h PRE-CREATION =
> src/transcoding/TranscodingOptionsStackedWidget.cpp PRE-CREATION =
> src/transcoding/TranscodingPropertyComboBoxWidget.h PRE-CREATION =
> src/transcoding/TranscodingPropertyComboBoxWidget.cpp PRE-CREATION =
> src/transcoding/TranscodingPropertySliderWidget.h PRE-CREATION =
> src/transcoding/TranscodingPropertySliderWidget.cpp PRE-CREATION =
> src/transcoding/TranscodingPropertySpinBoxWidget.h PRE-CREATION =
> src/transcoding/TranscodingPropertySpinBoxWidget.cpp PRE-CREATION =
> src/transcoding/TranscodingPropertyWidget.h PRE-CREATION =
> src/transcoding/TranscodingPropertyWidget.cpp PRE-CREATION =
> tests/core-impl/collections/sqlcollection/TestSqlCollectionLocation.cpp=
671759f =
> =
> Diff: http://git.reviewboard.kde.org/r/100068/diff
> =
> =
> Testing
> -------
> =
> The patch is the result of git diff for the range of several dozen transc=
oding-related commits prior to HEAD, rebased on current master, and should =
build. Transcoding from file browser to collection and inside sqlcollection=
should definitely work. FFmpeg is required, and Amarok should detect the e=
ncoders that are supported by your build of FFmpeg at runtime and populate =
the dialog accordingly.
> =
> =
> Thanks,
> =
> Teo
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100068/">http://git.reviewboard.kde.org/r/100068/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any progress on this \
one?</pre> <br />
<p>- Mark</p>
<br />
<p>On October 17th, 2010, 8:51 p.m., Teo Mrnjavac wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Teo Mrnjavac.</div>
<p style="color: grey;"><i>Updated 2010-10-17 20:51:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached diff is the work done during this summer to implement \
transcoding, it should apply to master as of right now. There are some known issues \
with how FFmpeg behaves with metadata, and I'm not sure I made all the right \
choices with how I modified CollectionLocation-related stuff.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch is the result of git diff for the range of several dozen \
transcoding-related commits prior to HEAD, rebased on current master, and should \
build. Transcoding from file browser to collection and inside sqlcollection should \
definitely work. FFmpeg is required, and Amarok should detect the encoders that are \
supported by your build of FFmpeg at runtime and populate the dialog \
accordingly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/App.cpp <span style="color: grey">(445fdc3)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(f8559c4)</span></li>
<li>src/browsers/CollectionTreeView.h <span style="color: \
grey">(63c99b5)</span></li>
<li>src/browsers/CollectionTreeView.cpp <span style="color: \
grey">(ed34beb)</span></li>
<li>src/browsers/filebrowser/FileView.h <span style="color: \
grey">(11547fe)</span></li>
<li>src/browsers/filebrowser/FileView.cpp <span style="color: \
grey">(9cb7c27)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.h \
<span style="color: grey">(f65cd4c)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.cpp \
<span style="color: grey">(a858d44)</span></li>
<li>src/core-impl/collections/sqlcollection/CMakeLists.txt <span style="color: \
grey">(f530d67)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlCollectionFactory.cpp <span \
style="color: grey">(a1966ac)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlCollectionLocation.h <span \
style="color: grey">(ec3a6d8)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlCollectionLocation.cpp <span \
style="color: grey">(4b023fc)</span></li>
<li>src/core/CMakeLists.txt <span style="color: grey">(5863ca1)</span></li>
<li>src/core/collections/CollectionLocation.h <span style="color: \
grey">(567f6d3)</span></li>
<li>src/core/collections/CollectionLocation.cpp <span style="color: \
grey">(dbf3b37)</span></li>
<li>src/core/transcoding/TranscodingConfiguration.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/TranscodingConfiguration.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/TranscodingController.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/TranscodingController.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/TranscodingDefines.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/TranscodingFormat.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/TranscodingProperty.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/TranscodingProperty.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingAacFormat.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingAacFormat.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingAlacFormat.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingAlacFormat.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingFlacFormat.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingFlacFormat.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingMp3Format.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingMp3Format.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingNullFormat.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingNullFormat.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingVorbisFormat.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingVorbisFormat.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingWmaFormat.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingWmaFormat.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/dialogs/OrganizeCollectionDialog.h <span style="color: \
grey">(2c0adf7)</span></li>
<li>src/dialogs/OrganizeCollectionDialog.cpp <span style="color: \
grey">(2607e99)</span></li>
<li>src/dialogs/TrackOrganizer.h <span style="color: grey">(9d62467)</span></li>
<li>src/dialogs/TrackOrganizer.cpp <span style="color: grey">(135d520)</span></li>
<li>src/transcoding/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingAssistantDialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingAssistantDialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingAssistantDialog.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingJob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingJob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingOptionsStackedWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingOptionsStackedWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingPropertyComboBoxWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingPropertyComboBoxWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingPropertySliderWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingPropertySliderWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingPropertySpinBoxWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingPropertySpinBoxWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingPropertyWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/transcoding/TranscodingPropertyWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/core-impl/collections/sqlcollection/TestSqlCollectionLocation.cpp <span \
style="color: grey">(671759f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100068/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic