[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Album Artist for QueryMaker
From: "Ralf Engels" <ralf-engels () gmx ! de>
Date: 2010-11-11 14:03:52
Message-ID: 20101111140352.10646.26741 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100135/#review334
-----------------------------------------------------------
Ship it!
Looks very sensible to me.
I haven't run the code but it looks very good all around.
- Ralf
On 2010-11-10 19:35:59, Sergey Ivanov wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100135/
> -----------------------------------------------------------
> =
> (Updated 2010-11-10 19:35:59)
> =
> =
> Review request for Amarok.
> =
> =
> Summary
> -------
> =
> Add new QueryType - AlbumArtist. Add new "level" to collection browser.
> It works well with SqlCollection, still need to make It work for all serv=
ices which support such queries.
> =
> =
> Diffs
> -----
> =
> src/amarokurls/NavigationUrlGenerator.cpp 5c48e73 =
> src/amarokurls/NavigationUrlRunner.cpp 2d6384b =
> src/browsers/CollectionTreeItemModelBase.h 23a189f =
> src/browsers/CollectionTreeItemModelBase.cpp 280245a =
> src/browsers/CollectionTreeView.cpp 2bb894c =
> src/browsers/collectionbrowser/CollectionWidget.cpp 8623079 =
> src/core-impl/collections/db/sql/SqlQueryMaker.h 680050f =
> src/core-impl/collections/db/sql/SqlQueryMaker.cpp ca105e8 =
> src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp 9002acf =
> src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.h 6=
3d6c2c =
> src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp=
c17c3fd =
> src/core-impl/collections/support/MemoryQueryMaker.h 72ddaf1 =
> src/core-impl/collections/support/MemoryQueryMaker.cpp 81bf9b6 =
> src/core-impl/collections/support/MemoryQueryMakerInternal.h db94d8b =
> src/core-impl/collections/support/MemoryQueryMakerInternal.cpp eeffd77 =
> src/core-impl/collections/support/XmlQueryReader.cpp b5518f0 =
> src/core-impl/collections/support/XmlQueryWriter.h 5caf7bc =
> src/core-impl/collections/support/XmlQueryWriter.cpp 3c9cf41 =
> src/core/collections/MetaQueryMaker.h 799825a =
> src/core/collections/MetaQueryMaker.cpp 10ae2a7 =
> src/core/collections/QueryMaker.h 9c15659 =
> src/core/collections/QueryMaker.cpp 78c6ba7 =
> src/core/meta/support/MetaConstants.h 73d03fc =
> src/core/meta/support/MetaUtility.cpp 5cf4519 =
> src/dialogs/TagDialog.h fbc89ae =
> src/dialogs/TagDialog.cpp ddd73cb =
> src/dialogs/TagDialogBase.ui 816ecb5 =
> src/services/ServiceSqlQueryMaker.h 5591ecc =
> src/services/ServiceSqlQueryMaker.cpp 197f2cf =
> src/services/ampache/AmpacheServiceQueryMaker.cpp 7dee8c8 =
> src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp 4dc8fed =
> src/services/scriptable/ScriptableServiceQueryMaker.cpp 76faca2 =
> =
> Diff: http://git.reviewboard.kde.org/r/100135/diff
> =
> =
> Testing
> -------
> =
> Tested with SqlCollection. Seems works for me. =
> =
> =
> Screenshots
> -----------
> =
> Only one album "Once". As It should be.
> http://git.reviewboard.kde.org/r/100135/s/17/
> 2 albums, and 3rd is somewhere below.
> http://git.reviewboard.kde.org/r/100135/s/18/
> =
> http://git.reviewboard.kde.org/r/100135/s/19/
> =
> =
> Thanks,
> =
> Sergey
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100135/">http://git.reviewboard.kde.org/r/100135/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks very sensible to \
me. I haven't run the code but it looks very good all around.</pre>
<br />
<p>- Ralf</p>
<br />
<p>On November 10th, 2010, 7:35 p.m., Sergey Ivanov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated 2010-11-10 19:35:59</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add new QueryType - AlbumArtist. Add new "level" to collection \
browser. It works well with SqlCollection, still need to make It work for all \
services which support such queries.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with SqlCollection. Seems works for me. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/amarokurls/NavigationUrlGenerator.cpp <span style="color: \
grey">(5c48e73)</span></li>
<li>src/amarokurls/NavigationUrlRunner.cpp <span style="color: \
grey">(2d6384b)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.h <span style="color: \
grey">(23a189f)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: \
grey">(280245a)</span></li>
<li>src/browsers/CollectionTreeView.cpp <span style="color: \
grey">(2bb894c)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.cpp <span style="color: \
grey">(8623079)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMaker.h <span style="color: \
grey">(680050f)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMaker.cpp <span style="color: \
grey">(ca105e8)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp <span style="color: \
grey">(9002acf)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.h <span \
style="color: grey">(63d6c2c)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp <span \
style="color: grey">(c17c3fd)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMaker.h <span style="color: \
grey">(72ddaf1)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMaker.cpp <span style="color: \
grey">(81bf9b6)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMakerInternal.h <span style="color: \
grey">(db94d8b)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMakerInternal.cpp <span \
style="color: grey">(eeffd77)</span></li>
<li>src/core-impl/collections/support/XmlQueryReader.cpp <span style="color: \
grey">(b5518f0)</span></li>
<li>src/core-impl/collections/support/XmlQueryWriter.h <span style="color: \
grey">(5caf7bc)</span></li>
<li>src/core-impl/collections/support/XmlQueryWriter.cpp <span style="color: \
grey">(3c9cf41)</span></li>
<li>src/core/collections/MetaQueryMaker.h <span style="color: \
grey">(799825a)</span></li>
<li>src/core/collections/MetaQueryMaker.cpp <span style="color: \
grey">(10ae2a7)</span></li>
<li>src/core/collections/QueryMaker.h <span style="color: \
grey">(9c15659)</span></li>
<li>src/core/collections/QueryMaker.cpp <span style="color: \
grey">(78c6ba7)</span></li>
<li>src/core/meta/support/MetaConstants.h <span style="color: \
grey">(73d03fc)</span></li>
<li>src/core/meta/support/MetaUtility.cpp <span style="color: \
grey">(5cf4519)</span></li>
<li>src/dialogs/TagDialog.h <span style="color: grey">(fbc89ae)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(ddd73cb)</span></li>
<li>src/dialogs/TagDialogBase.ui <span style="color: grey">(816ecb5)</span></li>
<li>src/services/ServiceSqlQueryMaker.h <span style="color: \
grey">(5591ecc)</span></li>
<li>src/services/ServiceSqlQueryMaker.cpp <span style="color: \
grey">(197f2cf)</span></li>
<li>src/services/ampache/AmpacheServiceQueryMaker.cpp <span style="color: \
grey">(7dee8c8)</span></li>
<li>src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp <span style="color: \
grey">(4dc8fed)</span></li>
<li>src/services/scriptable/ScriptableServiceQueryMaker.cpp <span style="color: \
grey">(76faca2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100135/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100135/s/17/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/06/AA_400x100.png" \
style="border: 1px black solid;" alt="Only one album "Once". As It should \
be." /></a>
<a href="http://git.reviewboard.kde.org/r/100135/s/18/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/06/AA1_400x100.png" \
style="border: 1px black solid;" alt="2 albums, and 3rd is somewhere below." /></a>
<a href="http://git.reviewboard.kde.org/r/100135/s/19/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/06/AA_1_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic