--===============0028955005== Content-Type: multipart/alternative; boundary="===============8588836896252255487==" --===============8588836896252255487== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-11-06 14:28:07, Stefan Derkits wrote: > > src/browsers/CollectionTreeItemModelBase.cpp, line 402 > > > > > > The plural of index is either indices or indexes ... but not indixe= s :) > = > Sergey Ivanov wrote: > Ah, my English terrible, so my excuses (overlooked 'i' tbh). :) No worries, 4 Eyes at least see more then 2 :) I think I've applied your patch & built Amarok with it, but can you post so= me Screenshots, especially of this "new level" - Stefan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/#review310 ----------------------------------------------------------- On 2010-11-06 14:41:00, Sergey Ivanov wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100135/ > ----------------------------------------------------------- > = > (Updated 2010-11-06 14:41:00) > = > = > Review request for Amarok. > = > = > Summary > ------- > = > Add new QueryType - AlbumArtist. Add new "level" to collection browser. > It works well with SqlCollection, still need to make It work for all serv= ices which support such queries. > = > = > Diffs > ----- > = > src/amarokurls/NavigationUrlGenerator.cpp 5c48e73 = > src/amarokurls/NavigationUrlRunner.cpp 2d6384b = > src/browsers/CollectionTreeItemModelBase.h 23a189f = > src/browsers/CollectionTreeItemModelBase.cpp 280245a = > src/browsers/collectionbrowser/CollectionWidget.cpp f493a5e = > src/core-impl/collections/db/sql/SqlQueryMaker.cpp ca105e8 = > src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp 9002acf = > src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp= c17c3fd = > src/core-impl/collections/support/MemoryQueryMaker.cpp 81bf9b6 = > src/core-impl/collections/support/MemoryQueryMakerInternal.cpp eeffd77 = > src/core-impl/collections/support/XmlQueryWriter.cpp 3c9cf41 = > src/core/collections/QueryMaker.h 9c15659 = > src/services/ServiceSqlQueryMaker.cpp 197f2cf = > src/services/ampache/AmpacheServiceQueryMaker.cpp 7dee8c8 = > src/services/scriptable/ScriptableServiceQueryMaker.cpp 76faca2 = > = > Diff: http://git.reviewboard.kde.org/r/100135/diff > = > = > Testing > ------- > = > Tested with SqlCollection. Seems works for me. = > = > = > Thanks, > = > Sergey > = > --===============8588836896252255487== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100135/

On November 6th, 2010, 2:28 p.m., Stefan De= rkits wrote:

= = =
src/browsers/CollectionTreeItemModelBase.cpp (Diff revision 1) 
CollectionTreeItemModelBase::mimeTypes() const
402 
CollectionTreeItemModelBase<=
/span>::mimeData(const QModelInd=
exList & indices) co=
nst
 402 
CollectionTreeItemModelBase<=
/span>::mimeData(const QModelInd=
exList & indixes) co=
nst
 
The plura=
l of index is either indices or indexes ... but not indixes :)

On November 6th, 2010, 2:38 p.m., Sergey Ivanov wrote:

Ah, my En=
glish terrible, so my excuses (overlooked 'i' tbh). :)
No worries, 4 Eyes at least see more then 2 :)

I think I've applied your patch & built Amarok with it, but can you=
 post some Screenshots, especially of this "new level"

- Stefan


On November 6th, 2010, 2:41 p.m., Sergey Ivanov wrote:

Review request for Amarok.
By Sergey Ivanov.

Updated 2010-11-06 14:41:00

Descripti= on 

Add new QueryType - AlbumArtist. Add new "level" t=
o collection browser.
It works well with SqlCollection, still need to make It work for all servic=
es which support such queries.

Testing <= /h1> 
Tested with SqlCollection. Seems works for me.

Diffs=

  • src/amarokurls/NavigationUrlGenerator.cpp = (5c48e73)
  • src/amarokurls/NavigationUrlRunner.cpp (2d= 6384b)
  • src/browsers/CollectionTreeItemModelBase.h (23a189f)
  • src/browsers/CollectionTreeItemModelBase.cpp (280245a)
  • src/browsers/collectionbrowser/CollectionWidget.cpp (f493a5e)
  • src/core-impl/collections/db/sql/SqlQueryMaker.cpp (ca105e8)
  • src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp (9002acf)
  • src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cp= p (c17c3fd)
  • src/core-impl/collections/support/MemoryQueryMaker.cpp (81bf9b6)
  • src/core-impl/collections/support/MemoryQueryMakerInternal.cpp (eeffd77)
  • src/core-impl/collections/support/XmlQueryWriter.cpp (3c9cf41)
  • src/core/collections/QueryMaker.h (9c15659= )
  • src/services/ServiceSqlQueryMaker.cpp (197= f2cf)
  • src/services/ampache/AmpacheServiceQueryMaker.cpp (7dee8c8)
  • src/services/scriptable/ScriptableServiceQueryMaker.cpp (76faca2)

View Diff
--===============8588836896252255487==-- --===============0028955005== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============0028955005==--