On November 6th, 2010, 2:28 p.m., Stefan Derkits wrote:
|
src/browsers/CollectionTreeItemModelBase.cpp
(Diff revision 1)
|
CollectionTreeItemModelBase::mimeTypes() const |
| 402 |
CollectionTreeItemModelBase::mimeData(const QModelIndexList & indices) const |
402 |
CollectionTreeItemModelBase::mimeData(const QModelIndexList & indixes) const |
The plural of index is either indices or indexes ... but not indixes :)
On November 6th, 2010, 2:38 p.m., Sergey Ivanov wrote:
Ah, my English terrible, so my excuses (overlooked 'i' tbh). :)
No worries, 4 Eyes at least see more then 2 :)
I think I've applied your patch & built Amarok with it, but can you post some Screenshots, especially of this "new level"
- Stefan
On November 6th, 2010, 2:41 p.m., Sergey Ivanov wrote:
|
Review request for Amarok.
By Sergey Ivanov.
Updated 2010-11-06 14:41:00
Description
Add new QueryType - AlbumArtist. Add new "level" to collection browser.
It works well with SqlCollection, still need to make It work for all services which support such queries.
|
Testing
Tested with SqlCollection. Seems works for me.
|
Diffs
- src/amarokurls/NavigationUrlGenerator.cpp (5c48e73)
- src/amarokurls/NavigationUrlRunner.cpp (2d6384b)
- src/browsers/CollectionTreeItemModelBase.h (23a189f)
- src/browsers/CollectionTreeItemModelBase.cpp (280245a)
- src/browsers/collectionbrowser/CollectionWidget.cpp (f493a5e)
- src/core-impl/collections/db/sql/SqlQueryMaker.cpp (ca105e8)
- src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp (9002acf)
- src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp (c17c3fd)
- src/core-impl/collections/support/MemoryQueryMaker.cpp (81bf9b6)
- src/core-impl/collections/support/MemoryQueryMakerInternal.cpp (eeffd77)
- src/core-impl/collections/support/XmlQueryWriter.cpp (3c9cf41)
- src/core/collections/QueryMaker.h (9c15659)
- src/services/ServiceSqlQueryMaker.cpp (197f2cf)
- src/services/ampache/AmpacheServiceQueryMaker.cpp (7dee8c8)
- src/services/scriptable/ScriptableServiceQueryMaker.cpp (76faca2)
View Diff
|