'Review Request: Album Artist for QueryMaker'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Review Request: Album Artist for QueryMaker
From:       "Sergey Ivanov" <123kash () gmail ! com>
Date:       2010-11-06 14:09:58
Message-ID: 20101106140958.19434.16271 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100135/
-----------------------------------------------------------

Review request for Amarok.

Summary
-------

Add new QueryType - AlbumArtist. Add new "level" to collection browser.
It works well with SqlCollection, still need to make It work for all servic=
es which support such queries.

Diffs
-----

  src/amarokurls/NavigationUrlGenerator.cpp 5c48e73 =

  src/amarokurls/NavigationUrlRunner.cpp 2d6384b =

  src/browsers/CollectionTreeItemModelBase.h 23a189f =

  src/browsers/CollectionTreeItemModelBase.cpp 280245a =

  src/browsers/collectionbrowser/CollectionWidget.cpp f493a5e =

  src/core-impl/collections/db/sql/SqlQueryMaker.cpp ca105e8 =

  src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp 9002acf =

  src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp c=
17c3fd =

  src/core-impl/collections/support/MemoryQueryMaker.cpp 81bf9b6 =

  src/core-impl/collections/support/MemoryQueryMakerInternal.cpp eeffd77 =

  src/core-impl/collections/support/XmlQueryWriter.cpp 3c9cf41 =

  src/core/collections/QueryMaker.h 9c15659 =

  src/services/ServiceSqlQueryMaker.cpp 197f2cf =

  src/services/ampache/AmpacheServiceQueryMaker.cpp 7dee8c8 =

  src/services/scriptable/ScriptableServiceQueryMaker.cpp 76faca2 =

Diff: http://git.reviewboard.kde.org/r/100135/diff

Testing
-------

Tested with SqlCollection. Seems works for me. =

Thanks,

Sergey

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100135/">http://git.reviewboard.kde.org/r/100135/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add new QueryType - AlbumArtist. Add new &quot;level&quot; to collection \
browser. It works well with SqlCollection, still need to make It work for all \
services which support such queries.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with SqlCollection. Seems works for me. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/amarokurls/NavigationUrlGenerator.cpp <span style="color: \
grey">(5c48e73)</span></li>

 <li>src/amarokurls/NavigationUrlRunner.cpp <span style="color: \
grey">(2d6384b)</span></li>

 <li>src/browsers/CollectionTreeItemModelBase.h <span style="color: \
grey">(23a189f)</span></li>

 <li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: \
grey">(280245a)</span></li>

 <li>src/browsers/collectionbrowser/CollectionWidget.cpp <span style="color: \
grey">(f493a5e)</span></li>

 <li>src/core-impl/collections/db/sql/SqlQueryMaker.cpp <span style="color: \
grey">(ca105e8)</span></li>

 <li>src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp <span style="color: \
grey">(9002acf)</span></li>

 <li>src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp <span \
style="color: grey">(c17c3fd)</span></li>

 <li>src/core-impl/collections/support/MemoryQueryMaker.cpp <span style="color: \
grey">(81bf9b6)</span></li>

 <li>src/core-impl/collections/support/MemoryQueryMakerInternal.cpp <span \
style="color: grey">(eeffd77)</span></li>

 <li>src/core-impl/collections/support/XmlQueryWriter.cpp <span style="color: \
grey">(3c9cf41)</span></li>

 <li>src/core/collections/QueryMaker.h <span style="color: \
grey">(9c15659)</span></li>

 <li>src/services/ServiceSqlQueryMaker.cpp <span style="color: \
grey">(197f2cf)</span></li>

 <li>src/services/ampache/AmpacheServiceQueryMaker.cpp <span style="color: \
grey">(7dee8c8)</span></li>

 <li>src/services/scriptable/ScriptableServiceQueryMaker.cpp <span style="color: \
grey">(76faca2)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100135/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 