--===============0972095980== Content-Type: multipart/alternative; boundary="===============1889705360717174797==" --===============1889705360717174797== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-11-01 19:21:36, Stefan Derkits wrote: > > The Colours in the Screenshot look a little bit strange (especially thi= s really light blue) and could need some Refinement > > And the Selection which Set of Tags to use should maybe be made by sele= cting it, instead of using checkboxes (because you can only select one tags= et) > > otherwise a good Improvement :) > = > Sergey Ivanov wrote: > I tried to make gradient Red->Green ( through orange ), but It looked= terrible, that's why I dropped blue color component. Color for MusicDNS w= as taken "from a roof", It's a simple Qt::cyan. They all can be changed, i.= e. waiting for your advices. :) > I think that checkboxes much more clear for understanding of selectio= n precess then simple row selection, and It prevents from: "WTF happened wi= th my tags, I didn't mean to accept this crap!?" > Btw mass-selection still available by clicking on a first header colu= mn, It automatically select all top results, except tracks that already has= result selected by user. > = > Thomas Pfeiffer wrote: > Looks good so far. But checkboxes are definitely the wrong control if= only one can be selected. Is it possible to use radio buttons? > The mass selection sounds like a useful feature, although I'd have to= see it in action to see if it can be understood. Maybe another Idea would be to use no Colour. First, because it's hard to f= ind Colours that look good in every Colour Scheme and second because a smal= l percentage of Colour Blind Users can't see them. So maybe instead of usin= g Colours, make an additional Collumn where you show the "Similarity Ratio"= as a numerical Value. Does MusicDNS not support any kind of Information "h= ow good the Results are"? - Stefan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100127/#review261 ----------------------------------------------------------- On 2010-11-01 18:35:41, Sergey Ivanov wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100127/ > ----------------------------------------------------------- > = > (Updated 2010-11-01 18:35:41) > = > = > Review request for Amarok. > = > = > Summary > ------- > = > Rebuild MBT dialog. Now search result presented by a Tree, trackToSearch-= >SearchResults. Search results sorted by similarity ratio ( more similar is= on top ), and has different colors corresponding to that. MusicDNS search = results marked with a cyan color and stay on bottom. There is no Start sear= ch button any more, both searches run simultaneously. > = > Will be Implemented soon: > 1) If one TrackID founded by both searches, this result automatically mov= es on top. > 2) MB icon linked to track page on musicbrainz.org. //need to find a plac= e for It > 3..n Needs your advices. :) > = > = > Diffs > ----- > = > src/CMakeLists.txt 2abeca2 = > src/dialogs/MusicBrainzTagger.h e33c9f6 = > src/dialogs/MusicBrainzTagger.cpp cdc3ec5 = > src/dialogs/MusicBrainzTagger.ui 3f14236 = > src/musicbrainz/MusicBrainzFinder.h 49c8f6b = > src/musicbrainz/MusicBrainzFinder.cpp 41ddbaa = > src/musicbrainz/MusicBrainzMeta.h 57ed363 = > src/musicbrainz/MusicBrainzTagsModel.h a93929a = > src/musicbrainz/MusicBrainzTagsModel.cpp 1bf7389 = > src/musicbrainz/MusicBrainzTrackListModel.h 6eaa648 = > src/musicbrainz/MusicBrainzTrackListModel.cpp fa1fc10 = > src/musicbrainz/MusicDNSFinder.h 2cd00d1 = > src/musicbrainz/MusicDNSFinder.cpp 9c31f38 = > = > Diff: http://git.reviewboard.kde.org/r/100127/diff > = > = > Testing > ------- > = > = > Screenshots > ----------- > = > Refreshed view of MusicBrainz tagger > http://git.reviewboard.kde.org/r/100127/s/10/ > Wide range diviation example, colors goes from red to green > http://git.reviewboard.kde.org/r/100127/s/11/ > = > = > Thanks, > = > Sergey > = > --===============1889705360717174797== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100127/ |
On November 1st, 2010, 7:21 p.m., Stefan De= rkits wrote:
The Colou= rs in the Screenshot look a little bit strange (especially this really ligh= t blue) and could need some Refinement And the Selection which Set of Tags to use should maybe be made by selectin= g it, instead of using checkboxes (because you can only select one tagset) otherwise a good Improvement :)On November 1st, 2010, 8:16 p.m., Sergey Ivanov wrote:
I tried t= o make gradient Red->Green ( through orange ), but It looked terrible, t= hat's why I dropped blue color component. Color for MusicDNS was taken= "from a roof", It's a simple Qt::cyan. They all can be chang= ed, i.e. waiting for your advices. :) I think that checkboxes much more clear for understanding of selection prec= ess then simple row selection, and It prevents from: "WTF happened wit= h my tags, I didn't mean to accept this crap!?" Btw mass-selection still available by clicking on a first header column, It= automatically select all top results, except tracks that already has resul= t selected by user.On November 1st, 2010, 9:10 p.m., Thomas Pfeiffer wrote:
Looks goo= d so far. But checkboxes are definitely the wrong control if only one can b= e selected. Is it possible to use radio buttons? The mass selection sounds like a useful feature, although I'd have to s= ee it in action to see if it can be understood.
Maybe anoth= er Idea would be to use no Colour. First, because it's hard to find Col= ours that look good in every Colour Scheme and second because a small perce= ntage of Colour Blind Users can't see them. So maybe instead of using C= olours, make an additional Collumn where you show the "Similarity Rati= o" as a numerical Value. Does MusicDNS not support any kind of Informa= tion "how good the Results are"?
- Stefan
On November 1st, 2010, 6:35 p.m., Sergey Ivanov wrote:
Review request for Amarok.
By Sergey Ivanov.
Updated 2010-11-01 18:35:41 Descripti= on
Diffs=
Screensho= ts |