From amarok-devel  Tue Nov 02 08:23:53 2010
From: "Stefan Derkits" <stefan () derkits ! at>
Date: Tue, 02 Nov 2010 08:23:53 +0000
To: amarok-devel
Subject: Re: Review Request: MusicBrainz Tagger "restyling"
Message-Id: <20101102082353.2779.97461 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=amarok-devel&m=128868629628263
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0972095980=="

--===============0972095980==
Content-Type: multipart/alternative;
	boundary="===============1889705360717174797=="

--===============1889705360717174797==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable



> On 2010-11-01 19:21:36, Stefan Derkits wrote:
> > The Colours in the Screenshot look a little bit strange (especially thi=
s really light blue) and could need some Refinement
> > And the Selection which Set of Tags to use should maybe be made by sele=
cting it, instead of using checkboxes (because you can only select one tags=
et)
> > otherwise a good Improvement :)
> =

> Sergey Ivanov wrote:
>     I tried to make gradient Red->Green ( through orange ), but It looked=
 terrible, that's why  I dropped blue color component. Color for MusicDNS w=
as taken "from a roof", It's a simple Qt::cyan. They all can be changed, i.=
e. waiting for your advices. :)
>     I think that checkboxes much more clear for understanding of selectio=
n precess then simple row selection, and It prevents from: "WTF happened wi=
th my tags, I didn't mean to accept this crap!?"
>     Btw mass-selection still available by clicking on a first header colu=
mn, It automatically select all top results, except tracks that already has=
 result selected by user.
> =

> Thomas Pfeiffer wrote:
>     Looks good so far. But checkboxes are definitely the wrong control if=
 only one can be selected. Is it possible to use radio buttons?
>     The mass selection sounds like a useful feature, although I'd have to=
 see it in action to see if it can be understood.

Maybe another Idea would be to use no Colour. First, because it's hard to f=
ind Colours that look good in every Colour Scheme and second because a smal=
l percentage of Colour Blind Users can't see them. So maybe instead of usin=
g Colours, make an additional Collumn where you show the "Similarity Ratio"=
 as a numerical Value. Does MusicDNS not support any kind of Information "h=
ow good the Results are"?


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100127/#review261
-----------------------------------------------------------


On 2010-11-01 18:35:41, Sergey Ivanov wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100127/
> -----------------------------------------------------------
> =

> (Updated 2010-11-01 18:35:41)
> =

> =

> Review request for Amarok.
> =

> =

> Summary
> -------
> =

> Rebuild MBT dialog. Now search result presented by a Tree, trackToSearch-=
>SearchResults. Search results sorted by similarity ratio ( more similar is=
 on top ), and has different colors corresponding to that. MusicDNS search =
results marked with a cyan color and stay on bottom. There is no Start sear=
ch button any more, both searches run simultaneously.
> =

> Will be Implemented soon:
> 1) If one TrackID founded by both searches, this result automatically mov=
es on top.
> 2) MB icon linked to track page on musicbrainz.org. //need to find a plac=
e for It
> 3..n Needs your advices. :)
> =

> =

> Diffs
> -----
> =

>   src/CMakeLists.txt 2abeca2 =

>   src/dialogs/MusicBrainzTagger.h e33c9f6 =

>   src/dialogs/MusicBrainzTagger.cpp cdc3ec5 =

>   src/dialogs/MusicBrainzTagger.ui 3f14236 =

>   src/musicbrainz/MusicBrainzFinder.h 49c8f6b =

>   src/musicbrainz/MusicBrainzFinder.cpp 41ddbaa =

>   src/musicbrainz/MusicBrainzMeta.h 57ed363 =

>   src/musicbrainz/MusicBrainzTagsModel.h a93929a =

>   src/musicbrainz/MusicBrainzTagsModel.cpp 1bf7389 =

>   src/musicbrainz/MusicBrainzTrackListModel.h 6eaa648 =

>   src/musicbrainz/MusicBrainzTrackListModel.cpp fa1fc10 =

>   src/musicbrainz/MusicDNSFinder.h 2cd00d1 =

>   src/musicbrainz/MusicDNSFinder.cpp 9c31f38 =

> =

> Diff: http://git.reviewboard.kde.org/r/100127/diff
> =

> =

> Testing
> -------
> =

> =

> Screenshots
> -----------
> =

> Refreshed view of MusicBrainz tagger
>   http://git.reviewboard.kde.org/r/100127/s/10/
> Wide range diviation example, colors goes from red to green
>   http://git.reviewboard.kde.org/r/100127/s/11/
> =

> =

> Thanks,
> =

> Sergey
> =

>


--===============1889705360717174797==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable




<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"http://git.reviewboard.kde.org/r/100127/">http://git.revie=
wboard.kde.org/r/100127/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; padd=
ing-left: 10px;">
 <p style=3D"margin-top: 0;">On November 1st, 2010, 7:21 p.m., <b>Stefan De=
rkits</b> wrote:</p>
 <blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; pad=
ding-left: 10px;">
  <pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-sp=
ace: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Colou=
rs in the Screenshot look a little bit strange (especially this really ligh=
t blue) and could need some Refinement
And the Selection which Set of Tags to use should maybe be made by selectin=
g it, instead of using checkboxes (because you can only select one tagset)
otherwise a good Improvement :)</pre>
 </blockquote>




 <p>On November 1st, 2010, 8:16 p.m., <b>Sergey Ivanov</b> wrote:</p>
 <blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; pad=
ding-left: 10px;">
  <pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-sp=
ace: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried t=
o make gradient Red-&gt;Green ( through orange ), but It looked terrible, t=
hat&#39;s why  I dropped blue color component. Color for MusicDNS was taken=
 &quot;from a roof&quot;, It&#39;s a simple Qt::cyan. They all can be chang=
ed, i.e. waiting for your advices. :)
I think that checkboxes much more clear for understanding of selection prec=
ess then simple row selection, and It prevents from: &quot;WTF happened wit=
h my tags, I didn&#39;t mean to accept this crap!?&quot;
Btw mass-selection still available by clicking on a first header column, It=
 automatically select all top results, except tracks that already has resul=
t selected by user.</pre>
 </blockquote>





 <p>On November 1st, 2010, 9:10 p.m., <b>Thomas Pfeiffer</b> wrote:</p>
 <blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; pad=
ding-left: 10px;">
  <pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-sp=
ace: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks goo=
d so far. But checkboxes are definitely the wrong control if only one can b=
e selected. Is it possible to use radio buttons?
The mass selection sounds like a useful feature, although I&#39;d have to s=
ee it in action to see if it can be understood.</pre>
 </blockquote>








</blockquote>

<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spac=
e: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe anoth=
er Idea would be to use no Colour. First, because it&#39;s hard to find Col=
ours that look good in every Colour Scheme and second because a small perce=
ntage of Colour Blind Users can&#39;t see them. So maybe instead of using C=
olours, make an additional Collumn where you show the &quot;Similarity Rati=
o&quot; as a numerical Value. Does MusicDNS not support any kind of Informa=
tion &quot;how good the Results are&quot;?</pre>
<br />








<p>- Stefan</p>


<br />
<p>On November 1st, 2010, 6:35 p.m., Sergey Ivanov wrote:</p>






<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.orgrb/images/=
review_request_box_top_bg.png'); background-position: left top; background-=
repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>


<p style=3D"color: grey;"><i>Updated 2010-11-01 18:35:41</i></p>




<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Rebuild MBT dialog. Now search result presented by a Tree, t=
rackToSearch-&gt;SearchResults. Search results sorted by similarity ratio (=
 more similar is on top ), and has different colors corresponding to that. =
MusicDNS search results marked with a cyan color and stay on bottom. There =
is no Start search button any more, both searches run simultaneously.

Will be Implemented soon:
1) If one TrackID founded by both searches, this result automatically moves=
 on top.
2) MB icon linked to track page on musicbrainz.org. //need to find a place =
for It
3..n Needs your advices. :)</pre>
  </td>
 </tr>
</table>





<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style=3D"color: grey">(2abeca2)</span></li>

 <li>src/dialogs/MusicBrainzTagger.h <span style=3D"color: grey">(e33c9f6)<=
/span></li>

 <li>src/dialogs/MusicBrainzTagger.cpp <span style=3D"color: grey">(cdc3ec5=
)</span></li>

 <li>src/dialogs/MusicBrainzTagger.ui <span style=3D"color: grey">(3f14236)=
</span></li>

 <li>src/musicbrainz/MusicBrainzFinder.h <span style=3D"color: grey">(49c8f=
6b)</span></li>

 <li>src/musicbrainz/MusicBrainzFinder.cpp <span style=3D"color: grey">(41d=
dbaa)</span></li>

 <li>src/musicbrainz/MusicBrainzMeta.h <span style=3D"color: grey">(57ed363=
)</span></li>

 <li>src/musicbrainz/MusicBrainzTagsModel.h <span style=3D"color: grey">(a9=
3929a)</span></li>

 <li>src/musicbrainz/MusicBrainzTagsModel.cpp <span style=3D"color: grey">(=
1bf7389)</span></li>

 <li>src/musicbrainz/MusicBrainzTrackListModel.h <span style=3D"color: grey=
">(6eaa648)</span></li>

 <li>src/musicbrainz/MusicBrainzTrackListModel.cpp <span style=3D"color: gr=
ey">(fa1fc10)</span></li>

 <li>src/musicbrainz/MusicDNSFinder.h <span style=3D"color: grey">(2cd00d1)=
</span></li>

 <li>src/musicbrainz/MusicDNSFinder.cpp <span style=3D"color: grey">(9c31f3=
8)</span></li>

</ul>

<p><a href=3D"http://git.reviewboard.kde.org/r/100127/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>



<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Screensho=
ts </h1>

<div>

 <a href=3D"http://git.reviewboard.kde.org/r/100127/s/10/"><img src=3D"http=
://git.reviewboard.kde.org/media/uploaded/images/2010/11/01/MBT_400x100.png=
" style=3D"border: 1px black solid;" alt=3D"Refreshed view of MusicBrainz t=
agger" /></a>

 <a href=3D"http://git.reviewboard.kde.org/r/100127/s/11/"><img src=3D"http=
://git.reviewboard.kde.org/media/uploaded/images/2010/11/01/MBT1_400x100.pn=
g" style=3D"border: 1px black solid;" alt=3D"Wide range diviation example, =
colors goes from red to green" /></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============1889705360717174797==--

--===============0972095980==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

--===============0972095980==--