[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Refactoring of FileType, get Type from Database,
From: "Stefan Derkits" <stefan () derkits ! at>
Date: 2010-10-30 16:57:01
Message-ID: 20101030165701.30170.5434 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100088/
-----------------------------------------------------------
(Updated 2010-10-30 16:57:01.568987)
Review request for Amarok.
Changes
-------
"Reverted" Refactoring (Amarok now again uses the enum everywhere)
FileType.cpp mostly implements static Helper Methods for use with FileTypes & has the List of \
all available FileTypes Also changed CollectionScanner to set the default Filetype based on the \
FileExtension
Summary
-------
Refactoring of FileType & some Changes that use the advantages of the new FileType Class:
-) Old enum FileType is now FileTypeEnum (still in there because it's needed to create the new \
FileType Objects)
-) Created new Class & some Helper Functions
-) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
-) Meta::SqlTrack.type() now gets it's Information from the Database instead of the \
FileExtension
Please give me your Feedback on this Patch.
One thing I don't really like that much is the Constructor. But without the enums the \
Constructor would have to use ugly Ints. An Option would be an additional Constructor that \
takes a QString as Argument (e.g. I could think of Amarok::FileType = "mp3"), and creates an \
Object by looking up the FileType in the QStringList.
Diffs (updated)
-----
shared/FileType.h 55c80b9
shared/FileType.cpp PRE-CREATION
src/CMakeLists.txt 5f2ac9d
src/browsers/CollectionTreeItemModelBase.cpp c25549b
src/core-impl/collections/sqlcollection/CMakeLists.txt f530d67
src/core-impl/collections/sqlcollection/SqlMeta.h afdf937
src/core-impl/collections/sqlcollection/SqlMeta.cpp b1a0694
src/core-impl/collections/support/MemoryFilter.cpp c076494
src/widgets/MetaQueryWidget.cpp 99e8993
tests/synchronization/CMakeLists.txt e5df2df
utilities/collectionscanner/CMakeLists.txt 70c86d0
utilities/collectionscanner/CollectionScanner.cpp 033ea84
Diff: http://git.reviewboard.kde.org/r/100088/diff
Testing
-------
Tested in the App, found no wrong Behaviour
Thanks,
Stefan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100088/">http://git.reviewboard.kde.org/r/100088/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Stefan Derkits.</div>
<p style="color: grey;"><i>Updated 2010-10-30 16:57:01.568987</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Reverted" \
Refactoring (Amarok now again uses the enum everywhere) FileType.cpp mostly implements static \
Helper Methods for use with FileTypes & has the List of all available FileTypes Also \
changed CollectionScanner to set the default Filetype based on the FileExtension</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Refactoring of \
FileType & some Changes that use the advantages of the new FileType Class:
-) Old enum FileType is now FileTypeEnum (still in there because it's needed to create the \
new FileType Objects)
-) Created new Class & some Helper Functions
-) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
-) Meta::SqlTrack.type() now gets it's Information from the Database instead of the \
FileExtension
Please give me your Feedback on this Patch.
One thing I don't really like that much is the Constructor. But without the enums the \
Constructor would have to use ugly Ints. An Option would be an additional Constructor that \
takes a QString as Argument (e.g. I could think of Amarok::FileType = "mp3"), and \
creates an Object by looking up the FileType in the QStringList.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in the App, \
found no wrong Behaviour</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/FileType.h <span style="color: grey">(55c80b9)</span></li>
<li>shared/FileType.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(5f2ac9d)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: \
grey">(c25549b)</span></li>
<li>src/core-impl/collections/sqlcollection/CMakeLists.txt <span style="color: \
grey">(f530d67)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.h <span style="color: \
grey">(afdf937)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.cpp <span style="color: \
grey">(b1a0694)</span></li>
<li>src/core-impl/collections/support/MemoryFilter.cpp <span style="color: \
grey">(c076494)</span></li>
<li>src/widgets/MetaQueryWidget.cpp <span style="color: grey">(99e8993)</span></li>
<li>tests/synchronization/CMakeLists.txt <span style="color: grey">(e5df2df)</span></li>
<li>utilities/collectionscanner/CMakeLists.txt <span style="color: grey">(70c86d0)</span></li>
<li>utilities/collectionscanner/CollectionScanner.cpp <span style="color: \
grey">(033ea84)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100088/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic