[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Add ability to hide/show menubar
From: "Valentyn Pavliuchenko" <valentyn.pavliuchenko () gmail ! com>
Date: 2010-10-17 10:53:46
Message-ID: 20101017105346.7827.855 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-16 15:25:10, Mark Kretschmann wrote:
> > After the changes that Valentyn made (especially the warning dialog), I am now in \
> > favor of merging this. I'd say, let's give it a try.
> >
> > Minor issues I noticed:
> >
> > There are grammar mistakes in the dialog, and it should have "Please" as the \
> > first word, to appear friendlier.
Sorry Mark, my English is not so good. Can you please commit it with my mistakes \
fixed?
- Valentyn
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100002/#review103
-----------------------------------------------------------
On 2010-10-09 21:39:52, Valentyn Pavliuchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100002/
> -----------------------------------------------------------
>
> (Updated 2010-10-09 21:39:52)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> Add Show Menubar to both main and popup menus to allow hiding/showing menu bar.
>
>
> This addresses bug 210020.
> https://bugs.kde.org/show_bug.cgi?id=210020
>
>
> Diffs
> -----
>
> src/MainWindow.h e6ae0b3
> src/MainWindow.cpp 0eb6b28
>
> Diff: http://git.reviewboard.kde.org/r/100002/diff
>
>
> Testing
> -------
>
> Tested functionality: all ok.
>
>
> Screenshots
> -----------
>
> Warning dialog
> http://git.reviewboard.kde.org/r/100002/s/4/
> Context menu
> http://git.reviewboard.kde.org/r/100002/s/5/
>
>
> Thanks,
>
> Valentyn
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100002/">http://git.reviewboard.kde.org/r/100002/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 16th, 2010, 3:25 p.m., <b>Mark \
Kretschmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After the changes that Valentyn made (especially the warning dialog), I \
am now in favor of merging this. I'd say, let's give it a try.
Minor issues I noticed:
There are grammar mistakes in the dialog, and it should have "Please" as \
the first word, to appear friendlier. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry Mark, my English \
is not so good. Can you please commit it with my mistakes fixed?</pre> <br />
<p>- Valentyn</p>
<br />
<p>On October 9th, 2010, 9:39 p.m., Valentyn Pavliuchenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Valentyn Pavliuchenko.</div>
<p style="color: grey;"><i>Updated 2010-10-09 21:39:52</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add Show Menubar to both main and popup menus to allow hiding/showing \
menu bar.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested functionality: all ok.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=210020">210020</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.h <span style="color: grey">(e6ae0b3)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(0eb6b28)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100002/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100002/s/4/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2010/10/09/auto9_400x100.png" \
style="border: 1px black solid;" alt="Warning dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/100002/s/5/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2010/10/09/auto10_400x100.png" \
style="border: 1px black solid;" alt="Context menu" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic