From amarok-devel Sun Oct 17 09:17:34 2010 From: "Stefan Derkits" Date: Sun, 17 Oct 2010 09:17:34 +0000 To: amarok-devel Subject: Re: Review Request: Add ability to hide/show menubar Message-Id: <20101017091734.4690.82780 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=amarok-devel&m=128730710116286 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0492894760==" --===============0492894760== Content-Type: multipart/alternative; boundary="===============4382525808623507252==" --===============4382525808623507252== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100002/#review106 ----------------------------------------------------------- Ship it! Looks good, ship it :) - Stefan On 2010-10-09 21:39:52, Valentyn Pavliuchenko wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100002/ > ----------------------------------------------------------- > = > (Updated 2010-10-09 21:39:52) > = > = > Review request for Amarok. > = > = > Summary > ------- > = > Add Show Menubar to both main and popup menus to allow hiding/showing men= u bar. > = > = > This addresses bug 210020. > https://bugs.kde.org/show_bug.cgi?id=3D210020 > = > = > Diffs > ----- > = > src/MainWindow.h e6ae0b3 = > src/MainWindow.cpp 0eb6b28 = > = > Diff: http://git.reviewboard.kde.org/r/100002/diff > = > = > Testing > ------- > = > Tested functionality: all ok. > = > = > Screenshots > ----------- > = > Warning dialog > http://git.reviewboard.kde.org/r/100002/s/4/ > Context menu > http://git.reviewboard.kde.org/r/100002/s/5/ > = > = > Thanks, > = > Valentyn > = > --===============4382525808623507252== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100002/

Ship it!

Looks good=
, ship it :)

- Stefan


On October 9th, 2010, 9:39 p.m., Valentyn Pavliuchenko wrote:

Review request for Amarok.
By Valentyn Pavliuchenko.

Updated 2010-10-09 21:39:52

Descripti= on 

Add Show Menubar to both main and popup menus to allow hidin=
g/showing menu bar.

Testing <= /h1> 
Tested functionality: all ok.
Bugs: 210020

Diffs=

  • src/MainWindow.h (e6ae0b3)
  • src/MainWindow.cpp (0eb6b28)

View Diff

Screensho= ts

3D"Warning 3D"Context
--===============4382525808623507252==-- --===============0492894760== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============0492894760==--