[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Usability improvement for collection setup dialog
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2010-10-09 14:30:46
Message-ID: 20101009143046.1551.62481 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100024/#review80
-----------------------------------------------------------
Ship it!
Patch works fine for me. Also the code looks clean, well documented and cor=
rect to me.
Merging into Mainline now.
- Mark
On 2010-10-06 08:08:07, James Duncan wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100024/
> -----------------------------------------------------------
> =
> (Updated 2010-10-06 08:08:07)
> =
> =
> Review request for Amarok.
> =
> =
> Summary
> -------
> =
> An improvement to the usability of the collection setup dialog,
> particularly in the inclusion and exclusion of folders under the
> 'recursive' mode.
> =
> =
> Diffs
> -----
> =
> src/dialogs/CollectionSetup.h 457c7ca =
> src/dialogs/CollectionSetup.cpp 0d22191 =
> =
> Diff: http://git.reviewboard.kde.org/r/100024/diff
> =
> =
> Testing
> -------
> =
> Lots of testing done. The patch passed all of my use cases and
> never forced a rescan when it wasn't necessary.
> =
> =
> Thanks,
> =
> James
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100024/">http://git.reviewboard.kde.org/r/100024/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch works fine for me. \
Also the code looks clean, well documented and correct to me.
Merging into Mainline now.
</pre>
<br />
<p>- Mark</p>
<br />
<p>On October 6th, 2010, 8:08 a.m., James Duncan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By James Duncan.</div>
<p style="color: grey;"><i>Updated 2010-10-06 08:08:07</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">An improvement to the usability of the collection setup dialog, \
particularly in the inclusion and exclusion of folders under the 'recursive' \
mode.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Lots of testing done. The patch passed all of my use cases and never \
forced a rescan when it wasn't necessary.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dialogs/CollectionSetup.h <span style="color: grey">(457c7ca)</span></li>
<li>src/dialogs/CollectionSetup.cpp <span style="color: grey">(0d22191)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100024/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic