--===============1849259974== Content-Type: multipart/alternative; boundary="===============3913899643539326052==" --===============3913899643539326052== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100000/ ----------------------------------------------------------- (Updated 2010-09-30 21:56:36.292868) Review request for amarok. Changes ------- Rebuild UI according to Thomas Pfeiffer comment. Summary ------- MusicBrainz and MusicDNS services support implementation. There are three independent parts: 1. MusicBrainzFinder class - used to make requests to MusicBrainz server an= d process replies. All relies process in separate threads by MusicBrainzXml= Parser class. For a search uses guessed from a file name track information.= No external dependences required. 2. MusicDNSFinder class - used for the same purpose as MusicBrainzFinder, b= ut i communicate with musicdns server and receives track's PUID as a reply.= Replies ether process in separate threads by MusicDNSXmlParser class. Fing= erprints generated by libofa (the only external dependence in entire patch)= . For track decompressing (MusicDNSAudioDecoder class) used xine engine (I'= m not sure is It a good choice, but amarok based on phonon media-engine, th= at uses xine. So we don't deed to pull any other dependences). Received PUI= Ds sends to MusicBrainzFinder class, for a search routine. 3. View. All classes used for store (MusicBrainzTagsModel, MusicBrainzTrack= ListModel) and display (MusicBrainzTagsModelDelegate) purposes. Diffs (updated) ----- CMakeLists.txt 191b02e = cmake/modules/FindLibOFA.cmake PRE-CREATION = config-amarok.h.cmake 981b7b7 = src/CMakeLists.txt ea5d155 = src/dialogs/MusicBrainzTagger.h PRE-CREATION = src/dialogs/MusicBrainzTagger.cpp PRE-CREATION = src/dialogs/MusicBrainzTagger.ui PRE-CREATION = src/dialogs/TagDialog.h 50cd801 = src/dialogs/TagDialog.cpp 68fc5e3 = src/dialogs/TagDialogBase.ui 9974d0b = src/musicbrainz/MusicBrainzFinder.h PRE-CREATION = src/musicbrainz/MusicBrainzFinder.cpp PRE-CREATION = src/musicbrainz/MusicBrainzMetaClasses.h PRE-CREATION = src/musicbrainz/MusicBrainzMetaClasses.cpp PRE-CREATION = src/musicbrainz/MusicBrainzTagsModel.h PRE-CREATION = src/musicbrainz/MusicBrainzTagsModel.cpp PRE-CREATION = src/musicbrainz/MusicBrainzTagsModelDelegate.h PRE-CREATION = src/musicbrainz/MusicBrainzTagsModelDelegate.cpp PRE-CREATION = src/musicbrainz/MusicBrainzTrackListModel.h PRE-CREATION = src/musicbrainz/MusicBrainzTrackListModel.cpp PRE-CREATION = src/musicbrainz/MusicBrainzXmlParser.h PRE-CREATION = src/musicbrainz/MusicBrainzXmlParser.cpp PRE-CREATION = src/musicbrainz/MusicDNSAudioDecoder.h PRE-CREATION = src/musicbrainz/MusicDNSAudioDecoder.cpp PRE-CREATION = src/musicbrainz/MusicDNSFinder.h PRE-CREATION = src/musicbrainz/MusicDNSFinder.cpp PRE-CREATION = src/musicbrainz/MusicDNSXmlParser.h PRE-CREATION = src/musicbrainz/MusicDNSXmlParser.cpp PRE-CREATION = Diff: http://git.reviewboard.kde.org/r/100000/diff Testing ------- Thanks, Sergey --===============3913899643539326052== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100000/

Review request for amarok.
By Sergey Ivanov.

Updated 2010-09-30 21:56:36.292868

Changes 
Rebuild UI according to Thomas Pfeiffer comment.

Descripti= on 

MusicBrainz and MusicDNS services support implementation.
There are three independent parts:
1. MusicBrainzFinder class - used to make requests to MusicBrainz server an=
d process replies. All relies process in separate threads by MusicBrainzXml=
Parser class. For a search uses guessed from a file name track information.=
  No external dependences required.
2. MusicDNSFinder class - used for the same purpose as MusicBrainzFinder, b=
ut i communicate with musicdns server and receives track's PUID as a re=
ply. Replies ether process in separate threads by MusicDNSXmlParser class. =
Fingerprints generated by libofa (the only external dependence in entire pa=
tch). For track decompressing (MusicDNSAudioDecoder class) used xine engine=
 (I'm not sure is It a good choice, but amarok based on phonon media-en=
gine, that uses xine. So we don't deed to pull any other dependences). =
Received PUIDs sends to MusicBrainzFinder class, for a search routine.
3. View. All classes used for store (MusicBrainzTagsModel, MusicBrainzTrack=
ListModel) and display (MusicBrainzTagsModelDelegate) purposes.

Diffs= (updated)

  • CMakeLists.txt (191b02e)
  • cmake/modules/FindLibOFA.cmake (PRE-CREATI= ON)
  • config-amarok.h.cmake (981b7b7)
  • src/CMakeLists.txt (ea5d155)
  • src/dialogs/MusicBrainzTagger.h (PRE-CREAT= ION)
  • src/dialogs/MusicBrainzTagger.cpp (PRE-CRE= ATION)
  • src/dialogs/MusicBrainzTagger.ui (PRE-CREA= TION)
  • src/dialogs/TagDialog.h (50cd801)
  • src/dialogs/TagDialog.cpp (68fc5e3)=
  • src/dialogs/TagDialogBase.ui (9974d0b)
  • src/musicbrainz/MusicBrainzFinder.h (PRE-C= REATION)
  • src/musicbrainz/MusicBrainzFinder.cpp (PRE= -CREATION)
  • src/musicbrainz/MusicBrainzMetaClasses.h (= PRE-CREATION)
  • src/musicbrainz/MusicBrainzMetaClasses.cpp (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTagsModel.h (PR= E-CREATION)
  • src/musicbrainz/MusicBrainzTagsModel.cpp (= PRE-CREATION)
  • src/musicbrainz/MusicBrainzTagsModelDelegate.h (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTagsModelDelegate.cpp (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTrackListModel.h (PRE-CREATION)
  • src/musicbrainz/MusicBrainzXmlParser.h (PR= E-CREATION)
  • src/musicbrainz/MusicBrainzXmlParser.cpp (= PRE-CREATION)
  • src/musicbrainz/MusicDNSAudioDecoder.h (PR= E-CREATION)
  • src/musicbrainz/MusicDNSAudioDecoder.cpp (= PRE-CREATION)
  • src/musicbrainz/MusicDNSFinder.h (PRE-CREA= TION)
  • src/musicbrainz/MusicDNSFinder.cpp (PRE-CR= EATION)
  • src/musicbrainz/MusicDNSXmlParser.h (PRE-C= REATION)
  • src/musicbrainz/MusicDNSXmlParser.cpp (PRE= -CREATION)

View Diff
--===============3913899643539326052==-- --===============1849259974== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============1849259974==--