[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Get FileType of SQLTracks from Database instead
From: "Stefan Derkits" <stefan () derkits ! at>
Date: 2010-09-28 8:11:05
Message-ID: 20100928081105.15802.75956 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-28 05:06:58, Dan Meltzer wrote:
> > For the most part I like this idea. If we are determining the informat=
ion already, then we should use it, rather than solving it again. That bei=
ng said, I think that even as deep as taglib, the extension is used when sc=
anning the file for metadata, so this isn't really going to solve the probl=
em that you wanted to solve.
Thanks you Dan for your Comments, will make a new Version of the Patch toda=
y to tackle the Issues you described.
Also I know that TagLib unfortunatley just uses the Extension, at least in =
the CollectionScanner. There seems to be a FiletypeResolver in the Amarok C=
ode that uses MimeTypes, but that uses the KMimeType Header and therefore c=
an't be used in the CollectionScanner ... will see if there is some Alterna=
tive
- Stefan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100004/#review28
-----------------------------------------------------------
On 2010-09-27 22:59:50, Stefan Derkits wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100004/
> -----------------------------------------------------------
> =
> (Updated 2010-09-27 22:59:50)
> =
> =
> Review request for amarok.
> =
> =
> Summary
> -------
> =
> -) Added a new Class Variable to SqlTrack to hold the FileType of a Track
> -) Retrieve FileType from Database and save it in the Class Variable
> -) Return a QString Representation of the Amarok::FileType when calling t=
he Method SqlTrack::type()
> =
> =
> Diffs
> -----
> =
> src/core-impl/collections/sqlcollection/SqlMeta.h ee3ec21 =
> src/core-impl/collections/sqlcollection/SqlMeta.cpp 2da0333 =
> =
> Diff: http://git.reviewboard.kde.org/r/100004/diff
> =
> =
> Testing
> -------
> =
> Hard to test, but the TagDialog displays the correct Filetypes
> Wanted to test it with a Testcase where FileType in Database is different=
then the FileExtension but realized that only certain FileExtensions are r=
ead by the CollectionScanner/TagLib :)
> So actually atm, the Code doesn't make much difference, but in my opinion=
this is a cleaner (and more future proof) Solution to display the Filetype=
then just displaying the Extension of the File
> =
> =
> Thanks,
> =
> Stefan
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100004/">http://git.reviewboard.kde.org/r/100004/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 28th, 2010, 5:06 a.m., <b>Dan \
Meltzer</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For the most part I like this idea. If we are determining the \
information already, then we should use it, rather than solving it again. That being \
said, I think that even as deep as taglib, the extension is used when scanning the \
file for metadata, so this isn't really going to solve the problem that you \
wanted to solve.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks you Dan for your \
Comments, will make a new Version of the Patch today to tackle the Issues you \
described.
Also I know that TagLib unfortunatley just uses the Extension, at least in the \
CollectionScanner. There seems to be a FiletypeResolver in the Amarok Code that uses \
MimeTypes, but that uses the KMimeType Header and therefore can't be used in the \
CollectionScanner ... will see if there is some Alternative</pre> <br />
<p>- Stefan</p>
<br />
<p>On September 27th, 2010, 10:59 p.m., Stefan Derkits wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for amarok.</div>
<div>By Stefan Derkits.</div>
<p style="color: grey;"><i>Updated 2010-09-27 22:59:50</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">-) Added a new Class Variable to SqlTrack to hold the FileType of a \
Track
-) Retrieve FileType from Database and save it in the Class Variable
-) Return a QString Representation of the Amarok::FileType when calling the Method \
SqlTrack::type()</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hard to test, but the TagDialog displays the correct Filetypes Wanted to \
test it with a Testcase where FileType in Database is different then the \
FileExtension but realized that only certain FileExtensions are read by the \
CollectionScanner/TagLib :) So actually atm, the Code doesn't make much \
difference, but in my opinion this is a cleaner (and more future proof) Solution to \
display the Filetype then just displaying the Extension of the File</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/sqlcollection/SqlMeta.h <span style="color: \
grey">(ee3ec21)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.cpp <span style="color: \
grey">(2da0333)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100004/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic