From amarok-devel Fri Sep 24 13:00:36 2010 From: "Sergey Ivanov" <123kash () gmail ! com> Date: Fri, 24 Sep 2010 13:00:36 +0000 To: amarok-devel Subject: Re: Review Request: MusicBrainz and MusicDNS services support Message-Id: <20100924130036.4225.69584 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=amarok-devel&m=128534402101022 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1071935912==" --===============1071935912== Content-Type: multipart/alternative; boundary="===============3898889711953001775==" --===============3898889711953001775== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100000/ ----------------------------------------------------------- (Updated 2010-09-24 13:00:36.289289) Review request for amarok. Changes ------- Rewrite It to use ffmpeg for decompression purposes. Return missed checks to src/CMakeLists.txt. Summary ------- MusicBrainz and MusicDNS services support implementation. There are three independent parts: 1. MusicBrainzFinder class - used to make requests to MusicBrainz server an= d process replies. All relies process in separate threads by MusicBrainzXml= Parser class. For a search uses guessed from a file name track information.= No external dependences required. 2. MusicDNSFinder class - used for the same purpose as MusicBrainzFinder, b= ut i communicate with musicdns server and receives track's PUID as a reply.= Replies ether process in separate threads by MusicDNSXmlParser class. Fing= erprints generated by libofa (the only external dependence in entire patch)= . For track decompressing (MusicDNSAudioDecoder class) used xine engine (I'= m not sure is It a good choice, but amarok based on phonon media-engine, th= at uses xine. So we don't deed to pull any other dependences). Received PUI= Ds sends to MusicBrainzFinder class, for a search routine. 3. View. All classes used for store (MusicBrainzTagsModel, MusicBrainzTrack= ListModel) and display (MusicBrainzTagsModelDelegate) purposes. Diffs (updated) ----- CMakeLists.txt 191b02e = cmake/modules/FindFFmpeg.cmake PRE-CREATION = cmake/modules/FindLibOFA.cmake PRE-CREATION = config-amarok.h.cmake 981b7b7 = src/CMakeLists.txt 42614ff = src/core-impl/capabilities/timecode/TimecodeEditCapability.h 6e15303 = src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp 8205d45 = src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h e35b57f = src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp 9be62= d9 = src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp 8bdbf75 = src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp b5cb08= 3 = src/core-impl/collections/sqlcollection/SqlMeta.h ee3ec21 = src/core-impl/collections/sqlcollection/SqlMeta.cpp 2da0333 = src/core-impl/meta/file/File.h 6d4d395 = src/core-impl/meta/file/File.cpp 30cd2ff = src/core-impl/meta/file/TagLibUtils.cpp 15b64a4 = src/core-impl/meta/proxy/MetaProxy.h 2ef3805 = src/core-impl/meta/proxy/MetaProxy.cpp 341e076 = src/core/capabilities/EditCapability.h 79344bd = src/dialogs/MusicBrainzTagger.h PRE-CREATION = src/dialogs/MusicBrainzTagger.cpp PRE-CREATION = src/dialogs/MusicBrainzTagger.ui PRE-CREATION = src/dialogs/TagDialog.h 50cd801 = src/dialogs/TagDialog.cpp 26d4eb8 = src/dialogs/TagDialogBase.ui 9974d0b = src/musicbrainz/DecodedAudioData.h PRE-CREATION = src/musicbrainz/DecodedAudioData.cpp PRE-CREATION = src/musicbrainz/MusicBrainzFinder.h PRE-CREATION = src/musicbrainz/MusicBrainzFinder.cpp PRE-CREATION = src/musicbrainz/MusicBrainzMetaClasses.h PRE-CREATION = src/musicbrainz/MusicBrainzMetaClasses.cpp PRE-CREATION = src/musicbrainz/MusicBrainzTagsModel.h PRE-CREATION = src/musicbrainz/MusicBrainzTagsModel.cpp PRE-CREATION = src/musicbrainz/MusicBrainzTagsModelDelegate.h PRE-CREATION = src/musicbrainz/MusicBrainzTagsModelDelegate.cpp PRE-CREATION = src/musicbrainz/MusicBrainzTrackListModel.h PRE-CREATION = src/musicbrainz/MusicBrainzTrackListModel.cpp PRE-CREATION = src/musicbrainz/MusicBrainzXmlParser.h PRE-CREATION = src/musicbrainz/MusicBrainzXmlParser.cpp PRE-CREATION = src/musicbrainz/MusicDNSAudioDecoder.h PRE-CREATION = src/musicbrainz/MusicDNSAudioDecoder.cpp PRE-CREATION = src/musicbrainz/MusicDNSFinder.h PRE-CREATION = src/musicbrainz/MusicDNSFinder.cpp PRE-CREATION = src/musicbrainz/MusicDNSXmlParser.h PRE-CREATION = src/musicbrainz/MusicDNSXmlParser.cpp PRE-CREATION = tests/core-impl/collections/proxycollection/TestProxyCollectionMeta.cpp 5= 5d1914 = Diff: http://git.reviewboard.kde.org/r/100000/diff Testing ------- Thanks, Sergey --===============3898889711953001775== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100000/

Review request for amarok.
By Sergey Ivanov.

Updated 2010-09-24 13:00:36.289289

Changes 
Rewrite It to use ffmpeg for decompression purposes.
Return missed checks to src/CMakeLists.txt.

Descripti= on 

MusicBrainz and MusicDNS services support implementation.
There are three independent parts:
1. MusicBrainzFinder class - used to make requests to MusicBrainz server an=
d process replies. All relies process in separate threads by MusicBrainzXml=
Parser class. For a search uses guessed from a file name track information.=
  No external dependences required.
2. MusicDNSFinder class - used for the same purpose as MusicBrainzFinder, b=
ut i communicate with musicdns server and receives track's PUID as a re=
ply. Replies ether process in separate threads by MusicDNSXmlParser class. =
Fingerprints generated by libofa (the only external dependence in entire pa=
tch). For track decompressing (MusicDNSAudioDecoder class) used xine engine=
 (I'm not sure is It a good choice, but amarok based on phonon media-en=
gine, that uses xine. So we don't deed to pull any other dependences). =
Received PUIDs sends to MusicBrainzFinder class, for a search routine.
3. View. All classes used for store (MusicBrainzTagsModel, MusicBrainzTrack=
ListModel) and display (MusicBrainzTagsModelDelegate) purposes.

Diffs= (updated)

  • CMakeLists.txt (191b02e)
  • cmake/modules/FindFFmpeg.cmake (PRE-CREATI= ON)
  • cmake/modules/FindLibOFA.cmake (PRE-CREATI= ON)
  • config-amarok.h.cmake (981b7b7)
  • src/CMakeLists.txt (42614ff)
  • src/core-impl/capabilities/timecode/TimecodeEditCapability.h (6e15303)
  • src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp (8205d45)
  • src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h (e35b57f)
  • src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp (9be62d9)
  • src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp (8bdbf75)
  • src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp (b5cb083)
  • src/core-impl/collections/sqlcollection/SqlMeta.h (ee3ec21)
  • src/core-impl/collections/sqlcollection/SqlMeta.cpp (2da0333)
  • src/core-impl/meta/file/File.h (6d4d395)
  • src/core-impl/meta/file/File.cpp (30cd2ff)=
  • src/core-impl/meta/file/TagLibUtils.cpp (1= 5b64a4)
  • src/core-impl/meta/proxy/MetaProxy.h (2ef3= 805)
  • src/core-impl/meta/proxy/MetaProxy.cpp (34= 1e076)
  • src/core/capabilities/EditCapability.h (79= 344bd)
  • src/dialogs/MusicBrainzTagger.h (PRE-CREAT= ION)
  • src/dialogs/MusicBrainzTagger.cpp (PRE-CRE= ATION)
  • src/dialogs/MusicBrainzTagger.ui (PRE-CREA= TION)
  • src/dialogs/TagDialog.h (50cd801)
  • src/dialogs/TagDialog.cpp (26d4eb8)=
  • src/dialogs/TagDialogBase.ui (9974d0b)
  • src/musicbrainz/DecodedAudioData.h (PRE-CR= EATION)
  • src/musicbrainz/DecodedAudioData.cpp (PRE-= CREATION)
  • src/musicbrainz/MusicBrainzFinder.h (PRE-C= REATION)
  • src/musicbrainz/MusicBrainzFinder.cpp (PRE= -CREATION)
  • src/musicbrainz/MusicBrainzMetaClasses.h (= PRE-CREATION)
  • src/musicbrainz/MusicBrainzMetaClasses.cpp (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTagsModel.h (PR= E-CREATION)
  • src/musicbrainz/MusicBrainzTagsModel.cpp (= PRE-CREATION)
  • src/musicbrainz/MusicBrainzTagsModelDelegate.h (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTagsModelDelegate.cpp (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTrackListModel.h (PRE-CREATION)
  • src/musicbrainz/MusicBrainzXmlParser.h (PR= E-CREATION)
  • src/musicbrainz/MusicBrainzXmlParser.cpp (= PRE-CREATION)
  • src/musicbrainz/MusicDNSAudioDecoder.h (PR= E-CREATION)
  • src/musicbrainz/MusicDNSAudioDecoder.cpp (= PRE-CREATION)
  • src/musicbrainz/MusicDNSFinder.h (PRE-CREA= TION)
  • src/musicbrainz/MusicDNSFinder.cpp (PRE-CR= EATION)
  • src/musicbrainz/MusicDNSXmlParser.h (PRE-C= REATION)
  • src/musicbrainz/MusicDNSXmlParser.cpp (PRE= -CREATION)
  • tests/core-impl/collections/proxycollection/TestProxyCollectionMeta.cp= p (55d1914)

View Diff
--===============3898889711953001775==-- --===============1071935912== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============1071935912==--