[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: MusicBrainz and MusicDNS services support
From: "Stefan Derkits" <stefan () derkits ! at>
Date: 2010-09-21 22:37:01
Message-ID: 20100921223701.805.95924 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100000/#review5
-----------------------------------------------------------
Personally I don't really like libofa because it looks like it is an abando=
ned Project without any current Maintainer
- Stefan
On 2010-09-21 19:48:56, Sergey Ivanov wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100000/
> -----------------------------------------------------------
> =
> (Updated 2010-09-21 19:48:56)
> =
> =
> Review request for amarok.
> =
> =
> Summary
> -------
> =
> MusicBrainz and MusicDNS services support implementation.
> There are three independent parts:
> 1. MusicBrainzFinder class - used to make requests to MusicBrainz server =
and process replies. All relies process in separate threads by MusicBrainzX=
mlParser class. For a search uses guessed from a file name track informatio=
n. No external dependences required.
> 2. MusicDNSFinder class - used for the same purpose as MusicBrainzFinder,=
but i communicate with musicdns server and receives track's PUID as a repl=
y. Replies ether process in separate threads by MusicDNSXmlParser class. Fi=
ngerprints generated by libofa (the only external dependence in entire patc=
h). For track decompressing (MusicDNSAudioDecoder class) used xine engine (=
I'm not sure is It a good choice, but amarok based on phonon media-engine, =
that uses xine. So we don't deed to pull any other dependences). Received P=
UIDs sends to MusicBrainzFinder class, for a search routine.
> 3. View. All classes used for store (MusicBrainzTagsModel, MusicBrainzTra=
ckListModel) and display (MusicBrainzTagsModelDelegate) purposes.
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt 191b02e =
> cmake/modules/FindLibOFA.cmake PRE-CREATION =
> config-amarok.h.cmake 981b7b7 =
> src/CMakeLists.txt b9a5d59 =
> src/core-impl/capabilities/timecode/TimecodeEditCapability.h 6e15303 =
> src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp 8205d45 =
> src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h e35b5=
7f =
> src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp 9be=
62d9 =
> src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp 8bdbf=
75 =
> src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp b5cb=
083 =
> src/core-impl/collections/sqlcollection/SqlMeta.h ee3ec21 =
> src/core-impl/collections/sqlcollection/SqlMeta.cpp 2da0333 =
> src/core-impl/meta/file/File.h 6d4d395 =
> src/core-impl/meta/file/File.cpp 30cd2ff =
> src/core-impl/meta/file/TagLibUtils.cpp 15b64a4 =
> src/core-impl/meta/proxy/MetaProxy.h 2ef3805 =
> src/core-impl/meta/proxy/MetaProxy.cpp 341e076 =
> src/core/capabilities/EditCapability.h 79344bd =
> src/dialogs/MusicBrainzTagger.h PRE-CREATION =
> src/dialogs/MusicBrainzTagger.cpp PRE-CREATION =
> src/dialogs/MusicBrainzTagger.ui PRE-CREATION =
> src/dialogs/TagDialog.h 50cd801 =
> src/dialogs/TagDialog.cpp 68fc5e3 =
> src/dialogs/TagDialogBase.ui 9974d0b =
> src/musicbrainz/MusicBrainzFinder.h PRE-CREATION =
> src/musicbrainz/MusicBrainzFinder.cpp PRE-CREATION =
> src/musicbrainz/MusicBrainzMetaClasses.h PRE-CREATION =
> src/musicbrainz/MusicBrainzMetaClasses.cpp PRE-CREATION =
> src/musicbrainz/MusicBrainzTagsModel.h PRE-CREATION =
> src/musicbrainz/MusicBrainzTagsModel.cpp PRE-CREATION =
> src/musicbrainz/MusicBrainzTagsModelDelegate.h PRE-CREATION =
> src/musicbrainz/MusicBrainzTagsModelDelegate.cpp PRE-CREATION =
> src/musicbrainz/MusicBrainzTrackListModel.h PRE-CREATION =
> src/musicbrainz/MusicBrainzTrackListModel.cpp PRE-CREATION =
> src/musicbrainz/MusicBrainzXmlParser.h PRE-CREATION =
> src/musicbrainz/MusicBrainzXmlParser.cpp PRE-CREATION =
> src/musicbrainz/MusicDNSAudioDecoder.h PRE-CREATION =
> src/musicbrainz/MusicDNSAudioDecoder.cpp PRE-CREATION =
> src/musicbrainz/MusicDNSFinder.h PRE-CREATION =
> src/musicbrainz/MusicDNSFinder.cpp PRE-CREATION =
> src/musicbrainz/MusicDNSXmlParser.h PRE-CREATION =
> src/musicbrainz/MusicDNSXmlParser.cpp PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/100000/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Sergey
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100000/">http://git.reviewboard.kde.org/r/100000/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Personally I don't \
really like libofa because it looks like it is an abandoned Project without any \
current Maintainer</pre> <br />
<p>- Stefan</p>
<br />
<p>On September 21st, 2010, 7:48 p.m., Sergey Ivanov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated 2010-09-21 19:48:56</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">MusicBrainz and MusicDNS services support implementation. There are \
three independent parts: 1. MusicBrainzFinder class - used to make requests to \
MusicBrainz server and process replies. All relies process in separate threads by \
MusicBrainzXmlParser class. For a search uses guessed from a file name track \
information. No external dependences required. 2. MusicDNSFinder class - used for \
the same purpose as MusicBrainzFinder, but i communicate with musicdns server and \
receives track's PUID as a reply. Replies ether process in separate threads by \
MusicDNSXmlParser class. Fingerprints generated by libofa (the only external \
dependence in entire patch). For track decompressing (MusicDNSAudioDecoder class) \
used xine engine (I'm not sure is It a good choice, but amarok based on phonon \
media-engine, that uses xine. So we don't deed to pull any other dependences). \
Received PUIDs sends to MusicBrainzFinder class, for a search routine. 3. View. All \
classes used for store (MusicBrainzTagsModel, MusicBrainzTrackListModel) and display \
(MusicBrainzTagsModelDelegate) purposes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(191b02e)</span></li>
<li>cmake/modules/FindLibOFA.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>config-amarok.h.cmake <span style="color: grey">(981b7b7)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b9a5d59)</span></li>
<li>src/core-impl/capabilities/timecode/TimecodeEditCapability.h <span style="color: \
grey">(6e15303)</span></li>
<li>src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp <span \
style="color: grey">(8205d45)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h <span \
style="color: grey">(e35b57f)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp <span \
style="color: grey">(9be62d9)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp <span \
style="color: grey">(8bdbf75)</span></li>
<li>src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp <span \
style="color: grey">(b5cb083)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.h <span style="color: \
grey">(ee3ec21)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.cpp <span style="color: \
grey">(2da0333)</span></li>
<li>src/core-impl/meta/file/File.h <span style="color: grey">(6d4d395)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(30cd2ff)</span></li>
<li>src/core-impl/meta/file/TagLibUtils.cpp <span style="color: \
grey">(15b64a4)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.h <span style="color: \
grey">(2ef3805)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.cpp <span style="color: \
grey">(341e076)</span></li>
<li>src/core/capabilities/EditCapability.h <span style="color: \
grey">(79344bd)</span></li>
<li>src/dialogs/MusicBrainzTagger.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/dialogs/MusicBrainzTagger.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/dialogs/MusicBrainzTagger.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/dialogs/TagDialog.h <span style="color: grey">(50cd801)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(68fc5e3)</span></li>
<li>src/dialogs/TagDialogBase.ui <span style="color: grey">(9974d0b)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzMetaClasses.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzMetaClasses.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModelDelegate.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModelDelegate.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzTrackListModel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzTrackListModel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzXmlParser.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzXmlParser.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicDNSAudioDecoder.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicDNSAudioDecoder.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicDNSFinder.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicDNSFinder.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicDNSXmlParser.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicDNSXmlParser.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100000/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic