This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100000/

Personally I don't really like libofa because it looks like it is an abandoned Project without any current Maintainer

- Stefan


On September 21st, 2010, 7:48 p.m., Sergey Ivanov wrote:

Review request for amarok.
By Sergey Ivanov.

Updated 2010-09-21 19:48:56

Description

MusicBrainz and MusicDNS services support implementation.
There are three independent parts:
1. MusicBrainzFinder class - used to make requests to MusicBrainz server and process replies. All relies process in separate threads by MusicBrainzXmlParser class. For a search uses guessed from a file name track information.  No external dependences required.
2. MusicDNSFinder class - used for the same purpose as MusicBrainzFinder, but i communicate with musicdns server and receives track's PUID as a reply. Replies ether process in separate threads by MusicDNSXmlParser class. Fingerprints generated by libofa (the only external dependence in entire patch). For track decompressing (MusicDNSAudioDecoder class) used xine engine (I'm not sure is It a good choice, but amarok based on phonon media-engine, that uses xine. So we don't deed to pull any other dependences). Received PUIDs sends to MusicBrainzFinder class, for a search routine.
3. View. All classes used for store (MusicBrainzTagsModel, MusicBrainzTrackListModel) and display (MusicBrainzTagsModelDelegate) purposes.

Diffs

  • CMakeLists.txt (191b02e)
  • cmake/modules/FindLibOFA.cmake (PRE-CREATION)
  • config-amarok.h.cmake (981b7b7)
  • src/CMakeLists.txt (b9a5d59)
  • src/core-impl/capabilities/timecode/TimecodeEditCapability.h (6e15303)
  • src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp (8205d45)
  • src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h (e35b57f)
  • src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp (9be62d9)
  • src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp (8bdbf75)
  • src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp (b5cb083)
  • src/core-impl/collections/sqlcollection/SqlMeta.h (ee3ec21)
  • src/core-impl/collections/sqlcollection/SqlMeta.cpp (2da0333)
  • src/core-impl/meta/file/File.h (6d4d395)
  • src/core-impl/meta/file/File.cpp (30cd2ff)
  • src/core-impl/meta/file/TagLibUtils.cpp (15b64a4)
  • src/core-impl/meta/proxy/MetaProxy.h (2ef3805)
  • src/core-impl/meta/proxy/MetaProxy.cpp (341e076)
  • src/core/capabilities/EditCapability.h (79344bd)
  • src/dialogs/MusicBrainzTagger.h (PRE-CREATION)
  • src/dialogs/MusicBrainzTagger.cpp (PRE-CREATION)
  • src/dialogs/MusicBrainzTagger.ui (PRE-CREATION)
  • src/dialogs/TagDialog.h (50cd801)
  • src/dialogs/TagDialog.cpp (68fc5e3)
  • src/dialogs/TagDialogBase.ui (9974d0b)
  • src/musicbrainz/MusicBrainzFinder.h (PRE-CREATION)
  • src/musicbrainz/MusicBrainzFinder.cpp (PRE-CREATION)
  • src/musicbrainz/MusicBrainzMetaClasses.h (PRE-CREATION)
  • src/musicbrainz/MusicBrainzMetaClasses.cpp (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTagsModel.h (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTagsModel.cpp (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTagsModelDelegate.h (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTagsModelDelegate.cpp (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTrackListModel.h (PRE-CREATION)
  • src/musicbrainz/MusicBrainzTrackListModel.cpp (PRE-CREATION)
  • src/musicbrainz/MusicBrainzXmlParser.h (PRE-CREATION)
  • src/musicbrainz/MusicBrainzXmlParser.cpp (PRE-CREATION)
  • src/musicbrainz/MusicDNSAudioDecoder.h (PRE-CREATION)
  • src/musicbrainz/MusicDNSAudioDecoder.cpp (PRE-CREATION)
  • src/musicbrainz/MusicDNSFinder.h (PRE-CREATION)
  • src/musicbrainz/MusicDNSFinder.cpp (PRE-CREATION)
  • src/musicbrainz/MusicDNSXmlParser.h (PRE-CREATION)
  • src/musicbrainz/MusicDNSXmlParser.cpp (PRE-CREATION)

View Diff