[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Patch for TagDialog - show Folder when editing
From: "Bart Cerneels" <bart.cerneels () kde ! org>
Date: 2010-09-20 11:27:51
Message-ID: 20100920112751.2011.29154 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/2/#review3
-----------------------------------------------------------
Ship it!
Looks OK
- Bart
On 2010-09-20 09:56:58, Stefan Derkits wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/2/
> -----------------------------------------------------------
> =
> (Updated 2010-09-20 09:56:58)
> =
> =
> Review request for amarok.
> =
> =
> Summary
> -------
> =
> Already submitted this Patch some Days ago via Mail, but I think it is ea=
sier to Review it here:
> =
> Amarok has the possibility to edit the Tags of Multiple Files e.g. an
> Album and shows only the Tags that are exactly the same in all the Files.
> =
> The only drawback of this for me was that I didn't see the Location
> (sometimes the Foldername, which is often the same for all Files in an
> Album, contains some Information I wanted to enter into the Tags) of the
> Files and had to check "per Track", remember the Information the
> Foldername revealed to me, uncheck "per Track" and enter the Information.
> =
> My Patch changes this in a Way, that if all Files are local and in the
> same Directory it still displays the Location Label, Location LineEdit &
> OpenButton in the TagDialog and sets the Text of the LineEdit to the
> Folder where all the Files are.
> =
> This way it is possible to see the Folder Name, even when you are
> editing multiple Files.
> =
> =
> Diffs
> -----
> =
> src/dialogs/TagDialog.cpp 68fc5e3 =
> =
> Diff: http://git.reviewboard.kde.org/r/2/diff
> =
> =
> Testing
> -------
> =
> Tested it in the App, the Folder shows up correctly when it should show u=
p and doesn't show up when it shouldn't
> =
> =
> Thanks,
> =
> Stefan
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/2/">http://git.reviewboard.kde.org/r/2/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks OK</pre> <br />
<p>- Bart</p>
<br />
<p>On September 20th, 2010, 9:56 a.m., Stefan Derkits wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for amarok.</div>
<div>By Stefan Derkits.</div>
<p style="color: grey;"><i>Updated 2010-09-20 09:56:58</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Already submitted this Patch some Days ago via Mail, but I think it is \
easier to Review it here:
Amarok has the possibility to edit the Tags of Multiple Files e.g. an
Album and shows only the Tags that are exactly the same in all the Files.
The only drawback of this for me was that I didn't see the Location
(sometimes the Foldername, which is often the same for all Files in an
Album, contains some Information I wanted to enter into the Tags) of the
Files and had to check "per Track", remember the Information the
Foldername revealed to me, uncheck "per Track" and enter the Information.
My Patch changes this in a Way, that if all Files are local and in the
same Directory it still displays the Location Label, Location LineEdit &
OpenButton in the TagDialog and sets the Text of the LineEdit to the
Folder where all the Files are.
This way it is possible to see the Folder Name, even when you are
editing multiple Files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested it in the App, the Folder shows up correctly when it should show \
up and doesn't show up when it shouldn't</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(68fc5e3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/2/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic