[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Running queries via dbus
From:       Alex Merry <kde () randomguy3 ! me ! uk>
Date:       2010-03-23 17:26:54
Message-ID: 201003231726.55285.kde () randomguy3 ! me ! uk
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 22 March 2010 22:05:26 Jacopo De Simoi wrote:
> > Ah, well the issue is that we're trying to pass back a float, but only
> > doubles are registered as valid D-Bus types by default.
> > 
> > In particular, Meta::Track has float as the return type of bpm(). 
> > Perhaps it would be sensible to make this a qreal?  Also, score() should
> > probably also return qreal (rather than double) for consistency.
> 
> Probably qreal would be the better choice; would it be possible to change
> it only when using dbus, to minimize interference with other parts of the
> code? As far as I can tell this issue makes the dbus query interface
> basically useless in most cases.

Well, yes, but it would be cleaner to just use qreal everywhere.

In fact, I have a commit sitting here that will do just that.

Should I commit it?  Esp. Jeff: how much will that screw up your reorganisation 
of meta/ stuff?

Alex

["signature.asc" (application/pgp-signature)]

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


[prev in list] [next in list] [prev in thread] [next in thread]