[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: [Amarok] d33a04f: fix volume/mute tooltip
From:       Myriam Schweingruber <myriam () kde ! org>
Date:       2010-03-07 23:37:47
Message-ID: c34709021003071537n320b9867o37b04d9ff0b2d7d4 () mail ! gmail ! com
[Download RAW message or body]

Thomas, you do know we are in string freeze, don't you? You just added
2 new strings...

On Sun, Mar 7, 2010 at 19:33, Thomas Lübking <thomas.luebking@web.de> wrote:
> commit d33a04f693751b74eb58ca9ba56ddb4a819aa431
> Author: Thomas Lübking <thomas.luebking@web.de>
> Date:   Sun Mar 7 19:35:25 2010 +0100
>
>    fix volume/mute tooltip
>
> diff --git a/src/widgets/VolumeDial.cpp b/src/widgets/VolumeDial.cpp
> index 4b79aa2..c2b9717 100644
> --- a/src/widgets/VolumeDial.cpp
> +++ b/src/widgets/VolumeDial.cpp
> @@ -298,15 +298,11 @@ void VolumeDial::setMuted( bool mute )
>
>     if ( mute )
>     {
> -        setToolTip( i18n( "Muted" ) );
>         m_unmutedValue = value();
>         setValue( minimum() );
>     }
>     else
> -    {
> -        setToolTip( i18n( "Volume: %1%", value() ) );
>         setValue( m_unmutedValue );
> -    }
>  }
>
>  QSize VolumeDial::sizeHint() const
> @@ -342,7 +338,7 @@ void VolumeDial::sliderChange( SliderChange change )
>
>  void VolumeDial::valueChangedSlot( int v )
>  {
> -    setToolTip( i18n( "Volume: %1%", v ) );
> +    setToolTip( ( v == minimum() ) ? i18n( "Muted" ) : i18n( "Volume: %1%", v ) );
>
>     m_isClick = false;
>
>



-- 
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread]