[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: git-svn users: please squash commits on branch merge
From:       Ian Monroe <ian.monroe () gmail ! com>
Date:       2009-07-05 11:59:54
Message-ID: f680fec50907050459w2c2e65fag46d3378da1361a85 () mail ! gmail ! com
[Download RAW message or body]

On Sun, Jul 5, 2009 at 6:49 AM, Soren Harward<stharward@gmail.com> wrote:
> On Sun, Jul 5, 2009 at 5:04 AM, Leo Franchi<lfranchi@kde.org> wrote:
>> You can however interactive rebase over a branch, and squash
>> unimportant commits into more important ones, leaving only the big
>> commits there.
>>
>> git rebase -i git-svn
>
> This is more sensible advice than the "always squash" mantra.
>
> I was just thinking that especially in my case, my fingerprinting
> system has 80-some commits, and the automated playlist generator has
> nearly 400 as of right now, and might exceed that before it's ready
> for trunk.  Nobody's gonna read all of those patches, especially since
> I've refactored or somehow redesigned large chunks of the APG code at
> least three times since I started.
>

Yea exactly. Commiting to trunk often is the best way to get reviewed,
but large commits are better then >10 commits which aren't going to be
reviewed at all.

So this thread doesn't apply to Nikolaj who dcommits often. :)

Ian
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread]