[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: extragear/multimedia/amarok
From:       Jeff Mitchell <mitchell () kde ! org>
Date:       2009-06-26 20:28:37
Message-ID: 4A452F75.3060506 () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Soren Harward wrote:
> On Fri, Jun 26, 2009 at 12:36 PM, Jeff Mitchell<mitchell@kde.org> wrote:
> > Ian, Alejandro and myself (at least) have multiple reservations about the changes \
> > made in this patch.  It needs review and testing before being pushed out to \
> > trunk, especially as it updates the database (in a way that is probably not \
> > correct).  This really needs to be put in a git branch first and tested out, or \
> > submitted as a patch to the mailing list for review.
> 
> Here's the patch against r987764.
> 
> But I'd like to point out that this isn't the first time I've
> submitted a patch to the ML for review.  I'm fine with it being
> reviewed before it gets committed.  But I'm not fine with people
> saying it must be reviewed before it gets committed, and then nobody
> ever reviewing it (especially those who insist on a review), and thus
> never letting me commit it.

I don't remember this patch being sent to the mailing list before.

Hopefully Ian and Alejandro will repeat the issues they pointed out in
IRC here.  As for me, I will look at the patch, but I'm going out of
town and may not have a chance before then, so it might be next week.

However, having just done a fuckload of fixing very broken things in
SqlCollection, I'd like to review the changes you're making to make sure
that the behavior is sane, and not just that it compiles against all the
changes I made.

Fortunately git will make this easier at some point.

--Jeff


["signature.asc" (application/pgp-signature)]

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


[prev in list] [next in list] [prev in thread] [next in thread]