[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: [PATCH] ReplayGain tags
From:       Alex Merry <kde () randomguy3 ! me ! uk>
Date:       2009-01-11 14:30:10
Message-ID: 200901111430.11373.kde () randomguy3 ! me ! uk
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 11 January 2009 12:57:59 Andrew Turner wrote:
> There is a good reason to check for dbVersion > DB_VERSION. Sometimes
> users upgrade to a new version of Amarok, which updates their
> database. Then something pisses them off and they try to go back to
> their old version. That check used to be used to prevent an old
> version of Amarok trying to use a newer Amarok's DB and doing
> unpredictable nastiness - it exited with a fatal error instead, I
> think. Not exactly user friendly, but probably nicer than deleting the
> user's statistics (and everything else).

Well, what it actually did in this case was to empty the tables then try to 
create them (which wouldn't have worked).

That said, I can easily put in a check that pops up an error message and quits 
amarok if the DB_VERSION is too high.  But such a thing should probably be 
backported (since it's only helpful if it exists in the old versions of 
Amarok).

Alex


PS: please don't top-post.


["signature.asc" (application/pgp-signature)]

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


[prev in list] [next in list] [prev in thread] [next in thread]