[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: ratings and scores use 0 for default value
From:       "Dan Meltzer" <parallelgrapefruit () gmail ! com>
Date:       2008-11-30 16:30:10
Message-ID: 46059ce10811300830u148acf1ft9d2efad70eadb225 () mail ! gmail ! com
[Download RAW message or body]

On Sat, Nov 29, 2008 at 8:17 PM, Caleb Cushing <xenoterracide@gmail.com> wrote:
> https://bugs.kde.org/show_bug.cgi?id=172112
>
> unrated and unscored should be null values in the database, not having
> them as null creates a problem when ever you want to set up a playlist
> that includes greater than certain ratings or scores. and unrated
> track should not be considered less than a rated track.

I think that the problem lies here.

In my opinion, unrated tracks should not be considdered in any query
where their is a condition based on rating.  Rating is assigned by the
user, if the user wants tracks that only have a certain rating, we
should obey this.  We cannot assume that unrated tracks are going to
recieve either a good or a bad rating, and therefore they should be
ignored by the queries.
>
> sql wise this is as simple as making sure the default value when
> creating tracks is null.
> --
> Caleb Cushing
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel@kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]