[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src
From:       "Big O" <illogical1 () gmail ! com>
Date:       2008-11-26 13:57:17
Message-ID: 797cc39c0811260557i60040912ye1c802b6d44a994c () mail ! gmail ! com
[Download RAW message or body]

On Wed, Nov 26, 2008 at 3:25 AM, Seb Ruiz <ruiz@kde.org> wrote:
> SVN commit 889155 by seb:
> 
> There's a potential crash when checking for the results of this query.
> It may or may not be the cause of the importer crash for people with
> funny characters in their tags, but would now silently fail instead of
> crashing when the track stats can't be updated. This is better than
> crashing, imho, especially so close to final release. A proper fix can
> be found later with more resolve.
> 
> M  +1 -1      collection/sqlcollection/SqlCollectionLocation.cpp
> M  +1 -1      databaseimporter/amarok14/FastForwardWorker.cpp
> 
> 
> --- trunk/extragear/multimedia/amarok/src/collection/sqlcollection/SqlCollectionLocation.cpp \
> #889154:889155 @@ -334,7 +334,7 @@
> if( result.isEmpty() )
> {
> warning() << "SQL Query returned no results:" << select;
> -            //continue;
> +            continue;
> }

Shouldn't you add a FIXME or comment of some kind to this?


> QString id = result.first();    //if result is empty something is going very wrong
> //the following sql was copied from SqlMeta.cpp
> --- trunk/extragear/multimedia/amarok/src/databaseimporter/amarok14/FastForwardWorker.cpp \
> #889154:889155 @@ -148,7 +148,7 @@
> debug() << c << " inserting track:" << track->playableUrl();
> }
> else
> -                debug() << c << "  track in collection (" << \
> track->collection()->location()->prettyLocation() << "):" << track->playableUrl(); \
> +                debug() << c << " track in collection (" << \
> track->collection()->location()->prettyLocation() << "):" << track->playableUrl(); 
> emit trackAdded( track );
> ++i;
> 



-- 
All your gmail are belong to us.


[prev in list] [next in list] [prev in thread] [next in thread]