[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: extragear/multimedia/amarok/src/scriptengine
From:       "Seb Ruiz" <ruiz () kde ! org>
Date:       2008-09-24 21:56:58
Message-ID: 60ebdd0b0809241456s2171d18ao860edcccf1b7e031 () mail ! gmail ! com
[Download RAW message or body]

2008/9/24 Dan Meltzer <parallelgrapefruit@gmail.com>:
> On Wed, Sep 24, 2008 at 7:08 AM, Seb Ruiz <ruiz@kde.org> wrote:
> > SVN commit 864254 by seb:
> > 
> > warnings--
> 
> Warnings in this case were a good way to see what was, and was not,
> yet implemented.... most of the Q_UNUSED were because the functions
> were stubs... can you put AMAROK_NOTIMPLEMENTED in there so that we
> still can keep track of them not being implemented?  Otherwise it's
> hiding a problem, not solving it.

Thank you, I am very aware of the NYI macro, however warnings are a
fundamentally idiotic way of determining if a method is not
implemented. Since this is not my code, I don't know if these methods
are intentionally left empty and are meant to be implemented by a
subclass etc, in which case NYI macro would be incorrect.

I'll leave it up to peter to do the correct thing, as it is his code.


> > 
> > 
> > M  +2 -2      AmarokEngineScript.cpp
> > M  +2 -1      AmarokLyricsScript.cpp
> > M  +2 -0      AmarokScriptableServiceScript.cpp
> > 
> > 
> > --- trunk/extragear/multimedia/amarok/src/scriptengine/AmarokEngineScript.cpp \
> > #864253:864254 @@ -170,7 +170,7 @@
> > 
> > void AmarokEngineScript::setDynamicMode( bool enable )
> > {
> > -
> > +        Q_UNUSED( enable );
> > }
> > 
> > void AmarokEngineScript::setRepeatPlaylist( bool enable )
> > @@ -200,7 +200,7 @@
> > 
> > void AmarokEngineScript::setFadeoutLength( int length )
> > {
> > -
> > +        Q_UNUSED( length );
> > }
> > }
> > 
> > --- trunk/extragear/multimedia/amarok/src/scriptengine/AmarokLyricsScript.cpp \
> > #864253:864254 @@ -66,7 +66,8 @@
> > void
> > AmarokLyricsScript::setLyricsForTrack( const QString& trackUrl, const QString& \
> > lyrics ) const {
> > -    debug() << "bar";
> > +    Q_UNUSED( trackUrl );
> > +    Q_UNUSED( lyrics );
> > }
> > 
> > QString
> > --- trunk/extragear/multimedia/amarok/src/scriptengine/AmarokScriptableServiceScript.cpp \
> > #864253:864254 @@ -26,6 +26,7 @@
> > 
> > StreamItem::StreamItem( QScriptEngine *engine )
> > {
> > +    Q_UNUSED( engine );
> > }
> > 
> > StreamItem::~StreamItem()
> > @@ -117,6 +118,7 @@
> > 
> > QScriptValue ScriptableServiceScript::ScriptableServiceScript_prototype_populate( \
> > QScriptContext *context, QScriptEngine *engine ) {
> > +    Q_UNUSED( context );
> > debug() << "prototype populating here!";
> > return engine->undefinedValue(); // Fixme: return something.
> > }
> > 
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel@kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
> 



-- 
Seb Ruiz

http://www.sebruiz.net/
http://amarok.kde.org/
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


[prev in list] [next in list] [prev in thread] [next in thread]