[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 486084] Collection scan failure for tracks with "inf dB" in REPLAYGAIN_TRACK_GAIN tag 
From:       "Tuomas Nurmi" <bugzilla_noreply () kde ! org>
Date:       2024-05-19 9:32:30
Message-ID: bug-486084-71684-FxKpalkK2P () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=486084

Tuomas Nurmi <tuomas@norsumanageri.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/mult
                   |                            |imedia/amarok/-/commit/8cd6
                   |                            |f9cd018d13ba1b3800a8db3cddc
                   |                            |4c70ed649
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Tuomas Nurmi <tuomas@norsumanageri.org> ---
Git commit 8cd6f9cd018d13ba1b3800a8db3cddc4c70ed649 by Tuomas Nurmi.
Committed on 17/05/2024 at 20:27.
Pushed by nurmi into branch 'master'.

Ignore any infinite values when reading replaygain tags

Apparently QString::toFloat converts them happily to qreals with infinite
value.
We don't really want them in database, however. Also edit
TestMetaTrack::testReplayGain
to check that inf gain is ignored.

M  +1    -0    ChangeLog
M  +3    -3    shared/MetaReplayGain.cpp
M  +5    -0    tests/core/meta/TestMetaTrack.cpp
M  +-    --    tests/data/audio/album/Track03.ogg

https://invent.kde.org/multimedia/amarok/-/commit/8cd6f9cd018d13ba1b3800a8db3cddc4c70ed649

-- 
You are receiving this mail because:
You are the assignee for the bug.=
[prev in list] [next in list] [prev in thread] [next in thread]