[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 431738] Amarok sometimes crashes when searching in Collection Browser
From:       "Tuomas Nurmi" <bugzilla_noreply () kde ! org>
Date:       2024-04-22 15:13:09
Message-ID: bug-431738-71684-t4ljtud1FQ () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=431738

Tuomas Nurmi <tuomas@norsumanageri.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/mult
                   |                            |imedia/amarok/-/commit/e3a1
                   |                            |4e6ed3aeb0800df2a781b5c999d
                   |                            |71e4d524c
         Resolution|---                         |FIXED

--- Comment #6 from Tuomas Nurmi <tuomas@norsumanageri.org> ---
Git commit e3a14e6ed3aeb0800df2a781b5c999d71e4d524c by Tuomas Nurmi.
Committed on 22/04/2024 at 14:41.
Pushed by nurmi into branch 'master'.

Avoid crash when a running SqlQueryMaker is deleted

Deletion only after a job has finished seems to prevent crashes in cases where
an already deleted job finishes and runs defaultEnd, and additionally cases
where SqlQueryMakerInternal is deleted during an sql query and it tries to emit
now deleted signals based on query results.

Also try to avoid running any further extra steps in SqlQueryMakerInternal::run
if
abort has been called.

Fixes a flaky test, hopefully fixes also fixes a related bug

M  +14   -1    src/core-impl/collections/db/sql/SqlQueryMaker.cpp
M  +13   -2    src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp
M  +2    -0    src/core-impl/collections/db/sql/SqlQueryMakerInternal.h

https://invent.kde.org/multimedia/amarok/-/commit/e3a14e6ed3aeb0800df2a781b5c999d71e4d524c

-- 
You are receiving this mail because:
You are the assignee for the bug.=
[prev in list] [next in list] [prev in thread] [next in thread]