[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 475528] Songs get deleted from local collection when new ones are added
From:       "Tuomas Nurmi" <bugzilla_noreply () kde ! org>
Date:       2024-04-20 11:52:06
Message-ID: bug-475528-71684-ZKA0hCi712 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=475528

--- Comment #6 from Tuomas Nurmi <tuomas@norsumanageri.org> ---
(In reply to Tuomas Nurmi from comment #4)
> Git commit 154e31b5b3002f0bb290ef55ec0eb6c612113e91 by Tuomas Nurmi.
> Committed on 20/04/2024 at 11:04.
> Pushed by nurmi into branch 'master'.
> 
> Fix erronous database query
> 
> After three days of debugging, refreshing related autotests, writing more
> tests,
> hunting for differences between autotest mock components and real ones and
> digging
> deep into database queries related to saving paths, I am happy to announce
> that I
> have a fix which changes a single _ to /.
> 
> I guess the original idea might have been to handle both unix and windows
> path
> separators. However, based on my digging, I think Qt does that anyhow in
> every case
> before anything is written to db. Also, the directories saved into db always
> come
> from MountPointManager's getRelativePath, which has never a trailing /, so
> the
> slash instead of underscore should always be a correct character here to
> match
> subdirectories.
> 
> M  +1    -1    src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp
> 
> https://invent.kde.org/multimedia/amarok/-/commit/
> 154e31b5b3002f0bb290ef55ec0eb6c612113e91

Your welcome!
I think I've hit this bug myself once or twice, too, but it was too random to
get a good grasp on where to inspect. Your observation on the substrings in
folder names was very valuable in finding the cause of this, so thank you for
that!

-- 
You are receiving this mail because:
You are the assignee for the bug.=
[prev in list] [next in list] [prev in thread] [next in thread]