[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 396907] Amarok crashes when user clicks on Help ---> Diagnostics, while running under 
From:       "Heiko Becker" <bugzilla_noreply () kde ! org>
Date:       2020-03-26 20:22:07
Message-ID: bug-396907-71684-wu9oDRGjWj () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=396907

Heiko Becker <heirecka@exherbo.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/ama
                   |                            |rok/4ae84cd433864f45b2130c2
                   |                            |7bca8a2c4c0ba0d5a

--- Comment #2 from Heiko Becker <heirecka@exherbo.org> ---
Git commit 4ae84cd433864f45b2130c27bca8a2c4c0ba0d5a by Heiko Becker.
Committed on 26/03/2020 at 20:21.
Pushed by heikobecker into branch 'master'.

Fix a crash when trying to open the DiagnosticDialog

The possibility to discover the preferred phonon backend is gone
since its qt5 port, causing
'KServiceTypeTrader::self()->preferredService( "PhononBackend" )' to
return a null pointer, which causes a crash later on.
Instead I borrowed some code from the old phonon kcm from
plasma-desktop and slightly modified it.

M  +1    -0    CMakeLists.txt
M  +83   -8    src/dialogs/DiagnosticDialog.cpp
M  +18   -0    src/dialogs/DiagnosticDialog.h

https://commits.kde.org/amarok/4ae84cd433864f45b2130c27bca8a2c4c0ba0d5a

-- 
You are receiving this mail because:
You are the assignee for the bug.=
[prev in list] [next in list] [prev in thread] [next in thread]