[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 391146] New: fix crash when some external APIs fail
From:       Zhouyang <bugzilla_noreply () kde ! org>
Date:       2018-02-27 7:13:42
Message-ID: bug-391146-71684 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=391146

            Bug ID: 391146
           Summary: fix crash when some external APIs fail
           Product: amarok
           Version: 2.8.0
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Services/MP3tunes
          Assignee: amarok-bugs-dist@kde.org
          Reporter: jiazhouyang09@gmail.com
                CC: unnamedrambler@gmail.com
  Target Milestone: 2.9

Created attachment 111040
  --> https://bugs.kde.org/attachment.cgi?id=111040&action=edit
patch of reported bugs

Hi,

I'm a PhD student. I analyzed Amarok source code and found some potential API
bugs that may cause crashes:

1. In src/services/mp3tunes/libmp3tunes/locker.c:1501:5, if "curl_easy_perform"
failed, there would be unexcepted results.

2. In src/services/mp3tunes/libmp3tunes/locker.c:1479:14, if "fopen" failed,
"hd_src" might cause a crash.

I think it's unsafe to assume the library function would be correct. It would
be better if we could handle the error properly.

Attached please find the patch against version 2.8.0. Hopefully, it can solve
these potential bugs.

Best,
Zhouyang

-- 
You are receiving this mail because:
You are the assignee for the bug.=
[prev in list] [next in list] [prev in thread] [next in thread]