[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 314854] regression with KDE 4.10: Lyrics background has the wrong colour
From:       Stefano Pettini via KDE Bugzilla <bugzilla_noreply () kde ! org>
Date:       2016-06-19 1:06:53
Message-ID: bug-314854-71684-0N4DsgHyms () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=314854

Stefano Pettini <stefano.pettini@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stefano.pettini@gmail.com

--- Comment #12 from Stefano Pettini <stefano.pettini@gmail.com> ---
Please review fix:
https://git.reviewboard.kde.org/r/128246/

I believe the look and feel of every context applet should be the same, that is
a lighter version of the highlight color. This is true for current track,
similar artist and other applets, so I support the opinion of the original bug
reporter.

I fixed the bug by making the textbox of the lyrics browser transparent.

The lyrics browser also has an "edit lyrics" mode. In this case, the textbox
background color is switched to the default on and switched back to transparent
after exiting the editing mode.

If you agree with the solution, please review the code and merge my patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist

[prev in list] [next in list] [prev in thread] [next in thread]