[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 358408] New: Amarok cannot fetch tabs from ultimate-guitar.com anymore
From:       via KDE Bugzilla <bugzilla_noreply () kde ! org>
Date:       2016-01-23 9:21:37
Message-ID: bug-358408-71684 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=358408

            Bug ID: 358408
           Summary: Amarok cannot fetch tabs from ultimate-guitar.com
                    anymore
           Product: amarok
           Version: unspecified
          Platform: Debian unstable
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Context View/Tabs
          Assignee: amarok-bugs-dist@kde.org
          Reporter: wnc7prog@yahoo.com
                CC: rainer.sigle@web.de

The tabs cannot be fetched because ultimate-guitar.com needs https to work now
but amarok tries to use http.

Reproducible: Always




This can be fixed by setting the method to "https" instead of "http":
From f1633c277192031cba0a26744bbe41fc687f74a4 Mon Sep 17 00:00:00 2001
From: WNC7 <wnc7prog@yahoo.com>
Date: Sat, 23 Jan 2016 10:10:11 +0100
Subject: [PATCH 1/1] Use https to fetch tabs because ultimate-guitar.com
 disabled http

---
 src/context/engines/tabs/TabsEngine.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/context/engines/tabs/TabsEngine.cpp
b/src/context/engines/tabs/TabsEngine.cpp
index 24a89df..6c0504c 100644
--- a/src/context/engines/tabs/TabsEngine.cpp
+++ b/src/context/engines/tabs/TabsEngine.cpp
@@ -244,7 +244,7 @@ TabsEngine::queryUltimateGuitar( const QString &artist,
const QString &title )
 {
     // Query UltimateGuitar.com (filtering guitar (tabs + chords) and bass
tabs)
     KUrl ultimateGuitarUrl;
-    ultimateGuitarUrl.setScheme( "http" );
+    ultimateGuitarUrl.setScheme( "https" );
     ultimateGuitarUrl.setHost( "www.ultimate-guitar.com" );
     ultimateGuitarUrl.setPath( "/search.php" );
     ultimateGuitarUrl.addQueryItem( "view_state", "advanced" );
-- 
2.7.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist

[prev in list] [next in list] [prev in thread] [next in thread]