[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 313504] Fix EBN Krazy errors where appropriate
From:       vedant agarwala <vedant.kota () gmail ! com>
Date:       2014-05-21 10:45:38
Message-ID: bug-313504-71684-NUGBCWHIgf () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=313504

vedant agarwala <vedant.kota@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|http://commits.kde.org/amar |http://commits.kde.org/amar
                   |ok/01a4ce741420f76c7945063e |ok/4e254c6107166ddf0838990e
                   |58a2ccd5acdd5209            |908dc885dad8f1ba

--- Comment #10 from vedant agarwala <vedant.kota@gmail.com> ---
Git commit 4e254c6107166ddf0838990e908dc885dad8f1ba by Vedant Agarwala, on
behalf of Frank Meerkoetter.
Committed on 25/08/2013 at 08:28.
Pushed by vedanta into branch 'tagguessing'.

EBN: Check for foreach loop issues.

Fixing a number of issues from
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
[...]
13. Check for foreach loop issues [foreach]...
[...]

Prefer a const reference over a copy. This patch is only a first
batch - fixing the simple cases.
REVIEW: 112199

M  +1    -1    shared/TagsFromFileNameGuesser.cpp
M  +1    -1    src/EngineController.cpp
M  +1    -1    src/OpmlParser.cpp
M  +1    -1    src/configdialog/dialogs/MetadataConfig.cpp
M  +1    -1    src/context/applets/labels/LabelsApplet.cpp
M  +1    -1    src/core-impl/collections/daap/DaapCollection.cpp
M  +1    -1    src/core-impl/collections/daap/daapreader/Reader.cpp
M  +1    -1    src/core-impl/collections/db/MountPointManager.cpp
M  +1    -1    src/core-impl/collections/db/sql/SqlCollectionLocation.cpp
M  +1    -1   
src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp
M  +2    -2   
src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp
M  +2    -2   
src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.cpp
M  +2    -2   
src/core-impl/collections/ipodcollection/support/IphoneMountPoint.cpp
M  +1    -1    src/core-impl/collections/playdarcollection/support/Query.cpp
M  +1    -1    src/core-impl/collections/support/CollectionManager.cpp
M  +1    -1   
src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp
M  +2    -2   
src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp
M  +3    -3   
src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp
M  +2    -2    src/core-impl/collections/upnpcollection/UpnpQuery.cpp
M  +1    -1    src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp
M  +4    -4   
src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.cpp
M  +1    -1    src/core-impl/meta/cue/CueFileSupport.cpp
M  +1    -1    src/core/transcoding/TranscodingConfiguration.cpp
M  +1    -1    src/core/transcoding/formats/TranscodingAacFormat.cpp
M  +1    -1    src/core/transcoding/formats/TranscodingFlacFormat.cpp
M  +1    -1    src/core/transcoding/formats/TranscodingMp3Format.cpp
M  +1    -1    src/core/transcoding/formats/TranscodingOpusFormat.cpp
M  +1    -1    src/core/transcoding/formats/TranscodingVorbisFormat.cpp
M  +1    -1    src/core/transcoding/formats/TranscodingWmaFormat.cpp
M  +1    -1    src/covermanager/CoverCache.cpp
M  +2    -2    src/databaseimporter/amarok14/FastForwardWorker.cpp
M  +1    -1    src/dialogs/CollectionSetup.cpp
M  +1    -1    src/dialogs/OrganizeCollectionDialog.cpp
M  +1    -1    src/dialogs/TagDialog.cpp
M  +1    -2    src/network/NetworkAccessViewer.cpp
M  +2    -2    src/playlist/layouts/PlaylistLayoutEditDialog.cpp
M  +2    -2    src/playlistmanager/file/KConfigSyncRelStore.cpp
M  +1    -1    src/services/lastfm/ScrobblerAdapter.cpp
M  +3    -3    src/services/lastfm/SynchronizationAdapter.cpp
M  +1    -1    src/services/opmldirectory/OpmlDirectoryView.cpp
M  +1    -1    src/statsyncing/Config.cpp
M  +1    -1    src/transcoding/TranscodingOptionsStackedWidget.cpp
M  +1    -1    src/widgets/FilenameLayoutWidget.cpp
M  +1    -1    utilities/collectionscanner/CollectionScanner.cpp

http://commits.kde.org/amarok/4e254c6107166ddf0838990e908dc885dad8f1ba

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist
[prev in list] [next in list] [prev in thread] [next in thread]