[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 327547] Last.fm Invalid session key error not handled: scrobbles silently lost until a
From:       <kiwiiii () gmail ! com>
Date:       2013-11-18 8:42:21
Message-ID: bug-327547-71684-Kb5muhPMQC () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=327547

--- Comment #4 from kiwiiii@gmail.com ---
Yes, if you tell me which solution to implement, as I'm not familiar at all
with Amarok source code.

The onWsError could help catch every invalid session key error, not just the
scrobbling, and start a re-authentication (but where should I add this code in
amarok?)
And  ScrobblerAdapter::slotScrobblesSubmitted could check the error and
resubmit in case of Invalid session key, if we know the onWsError has already
finished it's re-authentication. Or we could just do a scrobbler.submit() in
LastFmService::continueReconfiguring() (it does nothing if the cache is empty,
so no network overhead in the usual flow). The later solution seems better to
me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist
[prev in list] [next in list] [prev in thread] [next in thread]