[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 323802] amarok gives MySQL error on startup, no tracks in collection
From:       Matěj Laitl <matej () laitl ! cz>
Date:       2013-10-27 10:50:08
Message-ID: bug-323802-71684-9kyjtKWfFq () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=323802

Matěj Laitl <matej@laitl.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |2.9
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/amar
                   |                            |ok/00dd8b41143ce08d1f529b43
                   |                            |9a943fd9bd052341

--- Comment #14 from Matěj Laitl <matej@laitl.cz> ---
Git commit 00dd8b41143ce08d1f529b439a943fd9bd052341 by Matěj Laitl.
Committed on 27/10/2013 at 10:07.
Pushed by laitl into branch 'master'.

MySqlEmbeddedStorage: fix failure to start embedded server because of wrong
options

This was because we were passing --myisam-recover-options and this
options does not exist in MySQL 5.1 (and MariaDB). The *command-line*
option (as opposed to system variable name) to set recovery mode is
tricky:
MySQL <= 5.1: --myisam-recover [1]
MySQL >= 5.5: --myisam-recover-options, should also accept
              --myisam-recover [2]
MariaDB: --myisam-recover [3]

*However*, the *system variable name* has always been named
myisam_recover_options, that's why it worked in Amarok <= 2.8.

No need to backport this because of the above.

Simple fix is to rename the option to --myisam-recover
FIXED-IN: 2.9

[1] https://dev.mysql.com/doc/refman/5.1/en/myisam-start.html
[2] https://dev.mysql.com/doc/refman/5.5/en/myisam-start.html
[3] https://mariadb.com/kb/en/myisam-server-system-variables/

M  +1    -0    ChangeLog
M  +1    -1   
src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp

http://commits.kde.org/amarok/00dd8b41143ce08d1f529b439a943fd9bd052341

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist

[prev in list] [next in list] [prev in thread] [next in thread]