[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 319835] Crash while scanning collection (@SqlScanResultProcessor)
From:       Matěj Laitl <matej () laitl ! cz>
Date:       2013-06-26 17:48:49
Message-ID: bug-319835-71684-zpJgXwtKPm () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=319835

Matěj Laitl <matej@laitl.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |2.8
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/amar
                   |                            |ok/acf7cfabe5e51cef2704d76a
                   |                            |4312724ebf4abfcf

--- Comment #11 from Matěj Laitl <matej@laitl.cz> ---
Git commit acf7cfabe5e51cef2704d76a4312724ebf4abfcf by Matěj Laitl.
Committed on 26/06/2013 at 16:49.
Pushed by laitl into branch 'master'.

ScanManagers, ScanResultProcessors: don't call non-thread-safe code from a
thread

Excessive usage of direct Qt connections lead to a large amount of code
in various ScanResultProcessors being called from a non-main thread, but
the result processors didn't expected it, weren't thread-safe, which
lead to data races.

This fixes one confirmed crash and may fix more seemingly random Local
Collection updating behaviour.
FIXED-IN: 2.8

M  +1    -0    ChangeLog
M  +6    -5    src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp
M  +3    -2    src/core-impl/collections/db/sql/SqlScanResultProcessor.h
M  +3    -3    src/core-impl/collections/umscollection/UmsCollection.cpp
M  +1    -1    src/core-impl/collections/umscollection/UmsCollection.h
M  +13   -23   src/scanner/AbstractScanResultProcessor.cpp
M  +6    -5    src/scanner/AbstractScanResultProcessor.h
M  +12   -16   src/scanner/GenericScanManager.cpp
M  +13   -10   src/scanner/GenericScanManager.h
M  +1    -5    src/scanner/GenericScannerJob.cpp
M  +12   -17   src/scanner/GenericScannerJob.h
M  +7    -15   tests/scanner/TestGenericScanManager.cpp
M  +1    -1    tests/scanner/TestGenericScanManager.h

http://commits.kde.org/amarok/acf7cfabe5e51cef2704d76a4312724ebf4abfcf

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist

[prev in list] [next in list] [prev in thread] [next in thread]